Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

HTML How to Make a Website Responsive Web Design and Testing Write CSS Media Queries

Jeff Ripke
Jeff Ripke
41,989 Points
Posted by Jeff Ripke
Jeff Ripke
41,989 Points

Can't figure out what is wrong with this CSS.

I can't figure out what is wrong with this css, it looks right to me.

css/main.css 
@media screen and (min-width: 480px) {
  h1 {
    font-size: 2.5em
  }
}

a {
  text-decoration: none;
}

#wrapper {
  max-width: 940px;
  margin: 0 auto;
}

#logo {
  text-align: center;
  margin: 0;
}

h1, h2 {
  color: #fff;
}

nav a {
  color: #fff;
}

nav a:hover {
  color: #32673f;
}

h1 {
  font-family: Changa One, sans-serif;
  font-size: 1.75em;
  font-weight: normal;
}

img {
  max-width: 100%;
}

#gallery {
  margin: 0;
  padding: 0;
  list-style: none;
}

#gallery li {
  float: left;
  width: 45%;
  margin: 2.5%;
  background-color: #f5f5f5;
  color: #bdc3c7;
}

nav ul {
  list-style: none;
  margin: 0 10px;
  padding: 0;
}

nav li {
  display: inline-block;
}

nav a {
  font-weight: 800;
  padding: 15px 10px;
}

.profile-photo {
  display: block;
  margin: 0 auto 30px;
      max-width: 150px;
  border-radius: 100%;
}

.contact-info {
  list-style: none;
  padding: 0;
  margin: 0;
  font-size: 0.9em;
}

.contact-info a {
  display: block;
  min-height: 20px;
  background-repeat: no-repeat;
  background-size: 20px 20px;
  padding: 0 0 0 30px;
  margin: 0 0 10px;
}
Konrad Pilch
Konrad Pilch
2,435 Points
Konrad Pilch
Konrad Pilch
2,435 Points

It did effect other people styles. As it camed up like 5 times again . So im just assuming its media queries :) This is a tutorial which from what i remember queries were last as well .

We can see that theres a h1 font size allready declared which means he should put his query at the bottom as well.

4 Answers

Konrad Pilch
Konrad Pilch
2,435 Points
Konrad Pilch
Konrad Pilch
2,435 Points

Your media querie should be the last.

btw, next time tell us what is wrong. Unelss something else is wrong ;d

Jeff Kinley
Jeff Kinley
21,207 Points
Jeff Kinley
Jeff Kinley
21,207 Points

The order of media queries is dependent on whether you are developing mobile-first or desktop first. In this case, the order should not be causing an error. However, it will effect the cascade and the outcome of your styles.

Jeff Kinley
Jeff Kinley
21,207 Points
Jeff Kinley
Jeff Kinley
21,207 Points

Hi Jeff,

Looks like you are missing a semi-colon in your h1.

Try this:

@media screen and (min-width: 480px) {
  h1 {
    font-size: 2.5em;
  }
}

Missing semi-colons will get ya all the time. ; )

Kristopher Van Sant
PLUS
Kristopher Van Sant
Courses Plus Student 18,830 Points
Kristopher Van Sant
Kristopher Van Sant
Courses Plus Student 18,830 Points

Konrad and jkinley are both correct here. You are missing semi-colon and your media query should come at the end of the provided CSS. A h1 font-size of 1.75em is already declared in the CSS and this new media query needs to change that h1 font-size to something else, so in order for it to change the current h1 it must come at the end.

Jeff Ripke
Jeff Ripke
41,989 Points
Jeff Ripke
Jeff Ripke
41,989 Points

Thanks, putting it at the end corrected the issue.