Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript Basics (Retired) Making Decisions with Conditional Statements Improving the Random Number Guessing Game

Posted by Richard Soricelli
Richard Soricelli
6,363 Points

When the answer is correct on second guess the program still outputs the message as if the answer was wrong.

The program is functioning fine except that when I guess correctly the second time, it still outputs the wrong answer message while showing the same number that I guessed. (So if I guess wrong the first time, and guess 4 the second time it will say "Sorry. The number was 4."

Any ideas?

var correctGuess = false;
var randomNumber = Math.floor(Math.random() * 6 ) + 1;
var guess = prompt('I am thinking of a number between 1 and 6. What is it?');
if (parseInt(guess) === randomNumber ) {
  correctGuess = true;
} else if ( parseInt(guess) < randomNumber ) {
  var guessMore = prompt('Try again. The number I am thinking of is more than ' + guess);
  if ( parseInt(guess) === randomNumber ) {
    correctGuess = true;
  }
} else if ( parseInt(guess) > randomNumber ) {
    var guessLess = prompt('Try again. The number I am thinking of is less than ' + guess);
    if ( parseInt(guess) === randomNumber ) {
      correctGuess = true;
    }
}
if ( correctGuess ) {
    document.write('<p>You guessed the number!</p>');
} else {
    document.write('<p>Sorry. The number was ' + randomNumber + '.</p>');
}

2 Answers

Philip Gales
Philip Gales
15,193 Points

Your second guess stores the value entered into a new variable. It then passes the original guess to see if the second guess was correct.

  var guessMore = prompt('Try again. The number I am thinking of is more than ' + guess);
  if ( parseInt(guess) === randomNumber ) {

To fix this, use the new guess variable in the if statement.

  var guessMore = prompt('Try again. The number I am thinking of is more than ' + guess);
  if ( parseInt(guessMore ) === randomNumber ) {
Richard Soricelli
Richard Soricelli
6,363 Points
Richard Soricelli
Richard Soricelli
6,363 Points

Thanks Philip! When you start missing the easy things like that, it's time to take a break.

Philip Gales
Philip Gales
15,193 Points

Very true! Before you take a break though, you should vote my answer as 'best answer' by clicking 'best answer' next to the 'add comment' under my answer.