What is wrong with my code ?

Question

what am i doing wrong with my code?

Program.cs

using System;

namespace Treehouse.CodeChallenges
{
    class Program
    {
        static void Main()
        {
            Console.Write("Enter the number of times to print \"Yay!\": ");
            string inputS = Console.ReadLine();
            int input = int.Parse(inputS);
            while(true) 
            {
              int counter = 0;

                if(counter == input)
                 {
                   break;
                 }
               else
                {
                   counter++;
                   Console.WriteLine("Yay!");
                   continue;
                }

           }
        }
    }
}

Answer 1 · 2016-10-27T09:16:09Z

October 27, 2016 9:16am

It looks like you've created an infinite loop.

Inside your loop, you set counter to zero right before you compare it with the input. You probably should initialize the counter outside the loop.

Also, while your method can work, it might be clearer to put the counter test in the while expression. Then you won't need special code inside the loop to escape from it.

And a "continue" is never needed when it's the last thing in a loop.

Welcome to the Treehouse Community

Looking to learn something new?

Benneth Paredis

Benneth Paredis

What is wrong with my code ?

1 Answer

Steven Parker

Steven Parker

It looks like you've created an infinite loop.

Benneth Paredis

Benneth Paredis