Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Objects Delivering the MVP Applying a Discount Code

What is wrong with my block of code here (Applying Discount Code Challenge)

i think my code is correct, but the code challenge give me an error message and it said ( Make sure you call your new private method from the applyDiscountCode method. Make sure you set the this.discountCode = normalizeDiscountCode(discountCode) ) can someone please me to pass this code challenge

Order.java
public class Order {
  private String itemName;
  private int priceInCents;
  private String discountCode;

private String normalizeDiscountCode(String discountCode) {
    return discountCode.toUpperCase();
}

  public Order(String itemName, int priceInCents) {
    this.itemName = itemName;
    this.priceInCents = priceInCents;
  }

  public String getItemName() {
    return itemName;
  }

  public int getPriceInCents() {
    return priceInCents;
  }

  public String getDiscountCode() {
    return discountCode;
  }

  public void applyDiscountCode(String discountCode) {
    this.discountCode = discountCode;
  }
}
Example.java
public class Example {

  public static void main(String[] args) {
    // This is here just for example use cases.

    Order order = new Order(
            "Yoda PEZ Dispenser",
            600);

    // These are valid.  They are letters and the $ character only
    order.applyDiscountCode("abc");
    order.getDiscountCode(); // ABC

    order.applyDiscountCode("$ale");
    order.getDiscountCode(); // $ALE


    try {
      // This will throw an exception because it contains numbers
      order.applyDiscountCode("ABC123");
    } catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }
    try {
      // This will throw as well, because it contains a symbol.
      order.applyDiscountCode("w@w");
    }catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }

  }
}

3 Answers

David Dooley
David Dooley
3,028 Points

Try this,

public class Order {
  private String itemName;
  private int priceInCents;
  private String discountCode;

  public Order(String itemName, int priceInCents) {
    this.itemName = itemName;
    this.priceInCents = priceInCents;
  }

  public String getItemName() {
    return itemName;
  }

  public int getPriceInCents() {
    return priceInCents;
  }

  public String getDiscountCode() {
    return discountCode;
  }

  public void applyDiscountCode(String discountCode) {
    //We need to call our normailizeDC method and pass in the discount code
    this.discountCode = normalizeDiscountCode(discountCode);
  }
    private String normalizeDiscountCode(String discountCode) ){
     /*we pass this instance of our discount code into A Character Method that already exist in java which 
    which takes out discount code and makes it uppercase and returns it back to this.method (normalizeDiscountCode)*/

    return discountCode.toUpperCase();
  }          

}

This should work for you ;)

james south
seal-mask
.a{fill-rule:evenodd;}techdegree seal-36
james south
Front End Web Development Techdegree Graduate 33,271 Points

look at what the error is telling you to do - set the variable to the return of another method. myVar = myFunc(param) instead of myVar = param.

oh..... thanks by the way, but i already figure it out yesterday.