Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript and the DOM (Retiring) Getting a Handle on the DOM Practice Selecting Elements

Posted by Amy Tomey
Amy Tomey
12,847 Points

What am I missing that the links in gallery are not selected? I've tried it several ways, and can't see a solution.

I have tried document.getElementsByTagName, document.querySelectorAll with all of the following ("gallery a") ("gallery li a") ("gallery ul li a") ("ul#gallery a"). I have looked at MDN webdocs, W3School, the Javascript book by Jon Duckett... rewatched videos, and it might as well be written in Greek. I need more than just the answer.... I'd like to know WHY it works or doesn't work... Any assistance would be appreciated. I feel if I can understand this, It will go a long way to improving my understanding of the potential of Javascript.

js/app.js 
let navigationLinks = document.querySelectorAll("nav a");
let galleryLinks = document.querySelectorAll("gallery a");
let footerImages;
index.html 
<!DOCTYPE html>
<html>
  <head>
    <meta charset="utf-8">
    <title>Nick Pettit | Designer</title>
    <link rel="stylesheet" href="css/normalize.css">
    <link href='http://fonts.googleapis.com/css?family=Changa+One|Open+Sans:400italic,700italic,400,700,800' rel='stylesheet' type='text/css'>
    <link rel="stylesheet" href="css/main.css">
    <link rel="stylesheet" href="css/responsive.css">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
  </head>
  <body>
    <header>
      <a href="index.html" id="logo">
        <h1>Nick Pettit</h1>
        <h2>Designer</h2>
      </a>
      <nav>
        <ul>
          <li><a href="index.html" class="selected">Portfolio</a></li>
          <li><a href="about.html">About</a></li>
          <li><a href="contact.html">Contact</a></li>
        </ul>
      </nav>
    </header>
    <div id="wrapper">
      <section>
        <ul id="gallery">
          <li>
            <a href="img/numbers-01.jpg">
              <img src="img/numbers-01.jpg" alt="">
              <p>Experimentation with color and texture.</p>
            </a>
          </li>
          <li>
            <a href="img/numbers-02.jpg">
              <img src="img/numbers-02.jpg" alt="">
              <p>Playing with blending modes in Photoshop.</p>
            </a>
          </li>
        </ul>
      </section>
      <footer>
        <a href="http://twitter.com/nickrp"><img src="img/twitter-wrap.png" alt="Twitter Logo" class="social-icon"></a>
        <a href="http://facebook.com/nickpettit"><img src="img/facebook-wrap.png" alt="Facebook Logo" class="social-icon"></a>
        <p>&copy; 2016 Nick Pettit.</p>
      </footer>
    </div>
  <script src="js/app.js"></script>
  </body>
</html>

1 Answer

Peter Vann
Peter Vann
36,427 Points

Hi Amy!

Your main issue is that with querySelector and querySelectorAll, to target ids, you need a #, and for classes, you need a .

So you need ("#gallery a) and if gallery was a class, you'd need (".gallery a")

This passes all three tasks:

let navigationLinks = document.querySelectorAll("nav a"); // Task 1
let galleryLinks = document.querySelectorAll("#gallery a"); // Task 2
let footerImages = document.querySelectorAll("footer img"); // Task 3

Keep in mind, with getElementById, you don't use a # but with querySelector, you need it.

I hope that helps.

Stay safe and happy coding!