Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Object-Oriented Python Dice Roller RPG Roller

what am I doing wrong?

I can not pass this challenge!!! I need help, please !!!

dice.py
import random


class Die:
    def __init__(self, sides=2):
        if sides < 2:
            raise ValueError("Can't have fewer than two sides")
        self.sides = sides
        self.value = random.randint(1, sides)

    def __int__(self):
        return self.value

    def __add__(self, other):
        return int(self) + other

    def __radd__(self, other):
        return self + other

    class D20(Die):
    def __init__(self,sides=0):
        super().__init__(sides=20)
hands.py
from dice import D20

class Hand(list):

    def __init__(self, sides=0, die_class =D20):
        super().__init__()
        for _ in range(sides):
            self.append(die_class())

    @classmethod
    def roll(cls, sides=0):
        return cls(sides)

    @property
    def total(self):
        return sum(self)

h = Hand.roll(2) 
h.total

1 Answer

Steven Parker
Steven Parker
231,236 Points

Which task are you on?

It looks like you have code for task 2, but an issue that would prevent passing task 1.

Well, anyway, for task 1 you should not indent the first line of class D20.

For task 2 you'll need a way (perhaps a loop?) to fill your Hand with the proper number of D20 rolls.

Thank you, Steven Parker. It was the indentation that you pointed out in the task 1. The part of the loop that you are talking about is here:

for _ in range(sides):
            self.append(die_class())
Steven Parker
Steven Parker
231,236 Points

I missed that — I was expecting all the new code to be in the roll method.

But, he did say " I don't care how you do it", so good job!