using forEach instead of Reduce

Question

Hey everyone, quick question.

Before Guil used the Reduce method to get a total player score, I paused the video and tried to do it myself. The solution I came up with was to use a forEach method.

It seems to work, but just wanted to ask if this method is still a good way of getting a totalScore or would it be more beneficial to use the Reduce method as Guil did?

Code below. Thanks!

const Stats = (props) =>{

    const totalPlayers = props.players.length;

    let totalScore = 0;

    props.players.forEach(player => {
        totalScore = totalScore += player.score;
    });

    return(
        <table className="stats">
  <tbody>
    <tr>
      <td>Players:</td>
      <td>{totalPlayers}</td>
    </tr>
    <tr>
      <td>Total Points:</td>
      <td>{totalScore}</td>
    </tr>
  </tbody>
</table>

Answer 1 · 2021-12-17T03:06:13Z

December 17, 2021 3:06am

forEach() works for this, but most devs will tend toward another method for readability because you can define the expression outside of the method (as in let totalScore = ...), whereas you can't do that with forEach() because forEach always returns undefined. It would also depend on whether or not you were doing anything else with the data, as you cannot chain to forEach(), but you can chain with other methods (like map()).

This isn't directly related to your question, but I thought I would mention that your expression for calculating the totalScore, while it does work as it is written, is very bad form. It should be either totalScore += player.score or totalScore = totalScore + player.score

Welcome to the Treehouse Community

Looking to learn something new?

Jiten Mehta

Jiten Mehta

using forEach instead of Reduce

1 Answer

Jason Larson

Jason Larson