Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Objects Delivering the MVP Applying a Discount Code

this.discountCode error. There is a compil;e error. Not sure how I can call the normalizeDiscountMethod from applydiscou

I need help with this task. I know to uppercase letter you simply do discountCode.toUpperCase(). but i am unsure what the instruction wants me to do exactl;y and I am not sure about my code that much. Plase help. Thanks

Order.java
public class Order {
  private String itemName;
  private int priceInCents;
  private String discountCode;

  public Order(String itemName, int priceInCents) {
    this.itemName = itemName;
    this.priceInCents = priceInCents;
  }

  public String getItemName() {
    return itemName;
  }

  public int getPriceInCents() {
    return priceInCents;
  }

  public String getDiscountCode() {
    return discountCode;
  }

  public void applyDiscountCode(String discountCode) {
    this.discountCode = normalizeDiscountCode(String discountCode);
  }

  private String normalizeDiscountCode(String discountCode) {
    String discountCode = discountCode.toUpperCase();
    return discountCode;
  }
}
Example.java
public class Example {

  public static void main(String[] args) {
    // This is here just for example use cases.

    Order order = new Order(
            "Yoda PEZ Dispenser",
            600);

    // These are valid.  They are letters and the $ character only
    order.applyDiscountCode("abc");
    order.getDiscountCode(); // ABC

    order.applyDiscountCode("$ale");
    order.getDiscountCode(); // $ALE


    try {
      // This will throw an exception because it contains numbers
      order.applyDiscountCode("ABC123");
    } catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }
    try {
      // This will throw as well, because it contains a symbol.
      order.applyDiscountCode("w@w");
    }catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }

  }
}

1 Answer

andren
andren
28,558 Points

There are two issues with your code.

The first issue is in this line:

this.discountCode = normalizeDiscountCode(String discountCode);

You don't specify the type of the argument when you call a method, you only type the name of the variable you want to send to the method. So String should not be included in that method call.

The second issue is in this line:

String discountCode = discountCode.toUpperCase();

discountCode is a parameter in the method so a variable exists for it automatically within the method. By including the String type you are telling Java to create a new variable called discountCode, which is invalid due to it already being defined in the method. You can fix this issue by simply removing the String keyword, but you can also shorten the code in this method to just one line by combining the two lines into one like this:

return discountCode.toUpperCase()

That is the only code that needs to be present in the normalizeDiscountCode method. It directly returns the result of using the toUpperCase method on the discountCode variable which already exist in the method.