Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript Basics (Retired) Creating Reusable Code with Functions Create a max() Function

Joshua Emery
Joshua Emery
1,164 Points
Posted by Joshua Emery
Joshua Emery
1,164 Points

This worked in my mind but clearly not?

So lost with this task

script.js 
function max(lower, upper){
  if parseInt(lower) > parseInt(upper) { return lower}
  else { return upper }
}
Joseph Chiang
Joseph Chiang
3,942 Points
Joseph Chiang
Joseph Chiang
3,942 Points

Hi Josh,

For if statements, the syntax is this

if( /*condition*/) {
  //code
} else {
 //code
};

So in your case, try putting a pair of parentheses around the condition. Your logic is correct, just a simple syntax error! 

if( parseInt(lower) > parseInt(upper))

Cheers, Joseph

Joshua Emery
Joshua Emery
1,164 Points
Joshua Emery
Joshua Emery
1,164 Points

Thanks Joesph! That’s cleared it up for me

Joseph Chiang
Joseph Chiang
3,942 Points
Joseph Chiang
Joseph Chiang
3,942 Points

Glad I could help. Happy coding and keep asking questions!

1 Answer

Steven Parker
Steven Parker
231,269 Points
Steven Parker
Steven Parker
231,269 Points

As Joseph pointed out, you need parentheses around the conditional expression.

But also, the instructions of this exercise clearly state that the function "accepts two numbers as arguments", so you will not need to call "parseInt" on them.

It's also good practice to end statements with a semicolon.

  if (lower > upper) { return lower; }