Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Objects Delivering the MVP Applying a Discount Code

This method is letting in non-Letters instead of throwing an exception.

private String normalizeDiscountCode(String discountedCode) { boolean isLetter = true; char[] chars = discountedCode.toCharArray(); for(char c : chars) { if(!Character.isLetter(c)) { isLetter = false; }

  }
  if (isLetter == false)
  {
    throw new IllegalArgumentException("Invalid discount code.");
  }
  return discountedCode.toUpperCase();
}
Order.java
public class Order {
  private String itemName;
  private int priceInCents;
  private String discountCode;

    private String normalizeDiscountCode(String discountedCode)
    {
      boolean isLetter = true;
      char[] chars = discountedCode.toCharArray();
      for(char c : chars)
      {
        if(!Character.isLetter(c))
        {
           isLetter = false;
        } 

      }
      if (isLetter == false)
      {
        throw new IllegalArgumentException("Invalid discount code.");
      }
      return discountedCode.toUpperCase();
    }

    public Order(String itemName, int priceInCents) {
    this.itemName = itemName;
    this.priceInCents = priceInCents;
  }

  public String getItemName() {
    return itemName;
  }

  public int getPriceInCents() {
    return priceInCents;
  }

  public String getDiscountCode() {
    return discountCode;
  }

  public void applyDiscountCode(String discountCode) {

    try {

      this.discountCode = normalizeDiscountCode(discountCode);

    } catch (IllegalArgumentException iae) {

      System.out.println(iae.getMessage());  
    }



  }
}
Example.java
public class Example {

  public static void main(String[] args) {
    // This is here just for example use cases.

    Order order = new Order(
            "Yoda PEZ Dispenser",
            600);

    // These are valid.  They are letters and the $ character only
    order.applyDiscountCode("abc");
    order.getDiscountCode(); // ABC

    order.applyDiscountCode("$ale");
    order.getDiscountCode(); // $ALE


    try {
      // This will throw an exception because it contains numbers
      order.applyDiscountCode("ABC123");
    } catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }
    try {
      // This will throw as well, because it contains a symbol.
      order.applyDiscountCode("w@w");
    }catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }

  }
}

1 Answer

gmilan
gmilan
9,287 Points

i think i would start with isLetter. it's a method and should be written as isLetter(). whatever gets passed in the parenthesis is true or false, so you don't have to declare it as a boolean.