Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Android Android Activity Lifecycle Introducing SharedPreferences Saving and Retrieving Data with SharedPreferences

Yuri Arons
Yuri Arons
7,281 Points

Still stuck !!!

can somebody help me fix this damn code !

MainActivity.java
import android.view.View;
import android.os.Bundle;

public class MainActivity extends Activity {

  private static final String PREFS_FILE = "com.teamtreehouse.sharedpreferencesapp.preferences";
  private static final String KEY_CHECKBOX = "key_checkbox";
  private SharedPreferences.Editor mEditor;
  private SharedPreferences mSharedPreferences;
  public CheckBox mCheckBox;

  @Override
  protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);

    mCheckBox = (CheckBox) findViewById(R.id.checkBox);
    mSharedPreferences = getSharedPreferences(PREFS_FILE, Context.MODE_PRIVATE);
    mEditor = mSharedPreferences.edit();
    mSharedPreferences.getString(KEY_CHECKBOX, "");
  }

  @Override
  protected void onPause() {
  super.onPause();
    mEditor.putBoolean(KEY_CHECKBOX, mCheckBox.setChecked());
    mEditor.apply();

  }
}

2 Answers

Kevin Faust
Kevin Faust
15,353 Points

Hi

@Override
  protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);

    mCheckBox = (CheckBox) findViewById(R.id.checkBox);
    mSharedPreferences = getSharedPreferences(PREFS_FILE, Context.MODE_PRIVATE);
    mEditor = mSharedPreferences.edit();
    Boolean value = mSharedPreferences.getBoolean(KEY_CHECKBOX, false); //we are getting a boolean not a string. //and we want the default value to be false as stated in the instructions
   mCheckBox.setChecked(value); //put in the above boolean value. true will make it checked, false is unchecked
  }

  @Override
  protected void onPause() {
  super.onPause();
    mEditor.putBoolean(KEY_CHECKBOX, mCheckBox.isChecked()); //this is the method that u need to use which will //return a boolean value depending on if the checkbox is checked or not
    mEditor.apply();

  }

I added comments in the above code showing you where you went wrong.

Yuri Arons
Yuri Arons
7,281 Points

you saved me man !!! tnxs !