Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Objects Delivering the MVP Applying a Discount Code

sorry to bug

I really try to figure out this code but is hard for me, i know I have to separate each character with in the string but, i cant get the proper code. I would appreciate is I get more examples and not the actual answer please, i want to harness java. thanks

Order.java
public class Order {
  private String itemName;
  private int priceInCents;
  private String discountCode;

  public Order(String itemName, int priceInCents) {
    this.itemName = itemName;
    this.priceInCents = priceInCents;
  }
  private String normalizeDiscountCode(char dCode){
   String cd = "";
    for(char code : discountCode.toCharArray()){
    if(! Character.isLetter(dCode)){
      throw new IllegalArgumentException("Invalid discount code");
     }
    }
    this.discountCode = discountCode.toUpperCase();
    return discountCode;
  }
  public String getItemName() {
    return itemName;
  }

  public int getPriceInCents() {
    return priceInCents;
  }

  public String getDiscountCode() {
    return discountCode;
  }

  public void applyDiscountCode(String discountCode) {
    discountCode = normalizeDiscountCode(dCode);
  }
}
Example.java
public class Example {

  public static void main(String[] args) {
    // This is here just for example use cases.

    Order order = new Order(
            "Yoda PEZ Dispenser",
            600);

    // These are valid.  They are letters and the $ character only
    order.applyDiscountCode("abc");
    order.getDiscountCode(); // ABC

    order.applyDiscountCode("$ale");
    order.getDiscountCode(); // $ALE


    try {
      // This will throw an exception because it contains numbers
      order.applyDiscountCode("ABC123");
    } catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }
    try {
      // This will throw as well, because it contains a symbol.
      order.applyDiscountCode("w@w");
    }catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }

  }
}

1 Answer

Craig Dennis
STAFF
Craig Dennis
Treehouse Teacher

Hmm...I think you want to check your code variable you create in your loop and not the dCode argument passed in...note you have looped on discountCode which isn't in scope.

 for(char code : discountCode.toCharArray()){
    if(! Character.isLetter(dCode)){

Ensure your variables are all correct. This is looking close! Keep at it!

thanks sir , I already did it, but i really appreciated you comment.