Welcome to the Treehouse Community
Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.
Looking to learn something new?
Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.
Start your free trialLinus Karlsson
7,402 PointsSome feedback, please?
Hi All!
I have just posted my first website in HTML, CSS and JavaScript all done from scratch!
Here is the link: http://www.inresonance.se/index.html
If anybody would like to see it and give me some feedback I would be truly grateful!
3 Answers
Michael Werlinger
1,259 PointsFor your fist website it looks good! Great job overall!!
My only comments are very nit picky, there are some naming conventions that are entirely personal although there are some common practices.
Generally instead of Us maybe try About US
Instead of Latest maybe try News
I do see there is a contact email but I would adjust to make a contact us that shows the contact information you wish to show, for us lazy Americans that are just scanning for key words and would miss it only to become frustrated and leave due to our own downfalls of having patience, taking an appropriate amount of time and actually reading words :-P
I really like that your menu follows the page down. All of your links work nicely. Works in many formats and browsers.
Keep up the good work :-)
David Moorhead
18,005 PointsHello, Linus,
Nice website! I like that we visitors can see you and those with whom you work, and as a fellow designer, I enjoy the overall information and friendliness of the site.
I've possible text, format and style modifications available for your consideration, and I hesitate to write them in here without your assent. Frankly, reviewing web pages as well as their HTML and CSS files is what I do while sipping coffee after I've coded too much for too long. :))
David
Linus Karlsson
7,402 PointsThank you so much, David! That is exactly what I was going for: friendliness and easy accessible information.
Please don't hesitate to post your suggestions! It's always good for me to learn new stuff, and I'm not forced to use them anyways =)
I guess I could have done more in the CSS as far as coloration and shadows/depths goes, but I also like the 2D feeling since it in itself helps achieve an overall easiness and accessibility.
Many thanx!
David Moorhead
18,005 PointsHi, Linus,
Thanks for allowing me to enter some suggestions!
I'm a writer sometimes, and, at the moment, a web designer without notable distinction, yet while there's time, I very much enjoy studying other designers' work. I've written this post in good faith to you and to others who read it. Here goes.
The orange nav bar is good since orange shows in the logo, but that color as a border around the grouppic doesn't necessarily blend well with flesh tones nor Kristina's mauv-ish pullover. Perhaps, a medium- to darkish-grey border to blend with the dark jackets or with the text color? I saw the orange border bar atop the footer, too.
By the way, the grouppic loaded immediately yesterday; about two hours ago, the image loaded slowly in three or four rows from top to bottom. I think W3C markup validation service would solve that (infrequent?) problem.
During coding of my practice pages from scratch, I depend on W3C markup validation service and W3C CSS validation service for designers' best practices. I lean on those services knowing one day I'll have clients. That's a nod in W3C's direction.
The light-grey, spherical background image is fixed, which is nice. I'm guessing the image shows something that's meaningful in the industry.
I really enjoyed seeing the responsiveness of the "Us" page. At the smallest break point, I noticed the left and right text justification remained; the photo remained clear; the nav bar and footer remained put; and, the appearance of the horizontal scroll. (I got rid of the bottom scroll bar when constructing with CSS Grid. That's spoken by a near-novice designer.)
Using "The Latest Updates" page, linked index.html, as an introduction to the website means to me a step too near unusual, but I got over that. The inResonance logo is quite nice, and I've got this uncanny reflex for clicking a banner to return to a distinctive home page.
Since I'm a champion of UX, the one idea that dominates my thinking these days is empathy for site visitors. What are visitors expecting from my design, content, and text, and am I providing satisfactory experiences for my site's visitors? Just some thoughts.
Linus, I'm a proofer for proper spelling as well as a watcher for verbs matching their subjects. Some friends call me the Grammar Guardian, the Punctuation Patrol, and the Spelling Sanitizer. With those pungent descriptors in mind, you'll see [recommended revisions] in the following two paragraphs.
We primarily work with distributing RF and microwave components from US manufactures [manufacturers] (see 'Suppliers') for the Swedish and Scandinavian markets. Our customer ranges [Our customers range] from Telecom companies and research facilities to technologically leading Swedish universities.
If you need technical support or are interested in a [quotation? quote?] for one of our supplier's products[,] please reach out to us at info@inresonance.se or directly to our e-mail addresses that follow below. We aim to respond with a quote within 24h [24 hours] of any working day.
I am a bit confused with the wording of the locations of your one email address. Confusion began here: "…please reach out to us at info@inresonance.se or directly to our e-mail addresses that follow below." The email address is identical in both the sentence you wrote as well as in the footer. Right? This was the confusing part: "...or directly to our e-mail addresses that follow below." Is that phrase necessary, you think?
Whew! That’s all.
Best to You and All,
David
Linus Karlsson
7,402 PointsHi David!
Thank you so much! I'll go through this sometime down the road from now.
At the moment I am focusing on Swift 4.0, but thanks a million!
Linus Karlsson
7,402 PointsLinus Karlsson
7,402 PointsThan you for the nice feedback! I have today made some updates of the margins, here and there...
I know that some of the naming on my website is a bit unorthodox (Latest, Us, etc) but in this case I did it deliberately to make the website stand out a little bit more. I don't know if I'm achieving my goal, but time will tell I suppose. Is there any major faults that will cause troubles with the names I have chosen do you think?
I don't quite understand what you mean with the comment
Do you think it's too little to only have a info-address listed under Us?
Cheers a million!