Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Python Basics (2015) Shopping List App Refactor

refactoring help, anyone?

I'm only being asked to put the last chunk of code which calls all of the above functions into one function called "main". Could anyone tell me if there is something to do here other than define "main" and adjust the position of any blocks so that they fit "inside" of it, or if I've failed to do that properly? Thank you to anyone who has any advice. I know it's a newb problem.

shopping_list.py
def show_help():
    # print out instructions on how to use the app
    print("What should we pick up at the store?")
    print("""
Enter 'DONE' to stop adding items.
Enter 'HELP' for this help.
Enter 'SHOW' to see your current list.
""")

def show_list(shopping_list):
    # print out the list
    print("Here's your list:")

    for item in shopping_list:
        print(item)

def add_to_list(shopping_list, new_item):
    # add new items to our list
    shopping_list.append(new_item)
    print("Added {}. List now has {} items.".format(new_item, len(shopping_list)))
    return shopping_list

def main():
    show_help()
# make a list to hold onto our items
    shopping_list = []
while True:
    # ask for new items
    new_item = input("> ")
    # be able to quit the app
    if new_item == 'DONE':
        break
    elif new_item == 'HELP':
        show_help()
        continue
    elif new_item == 'SHOW':
        show_list(shopping_list)
        continue
add_to_list(shopping_list, new_item)
show_list(shopping_list)

1 Answer

Chris Freeman
MOD
Chris Freeman
Treehouse Moderator 68,457 Points

You are correct that the challenge is simply defining the main() function and shifting everything over evenly. You are also correct that you have indentation issues. Look at the original code from the challenge. Make your code follow the same relative indentation pattern

show_help()

# make a list to hold onto our items
shopping_list = []

while True:
    # ask for new items
    new_item = input("> ")

    # be able to quit the app
    if new_item == 'DONE':
        break
    elif new_item == 'HELP':
        show_help()
        continue
    elif new_item == 'SHOW':
        show_list(shopping_list)
        continue
    add_to_list(shopping_list, new_item)

show_list(shopping_list)
Robin Johannessen
Robin Johannessen
1,575 Points

I would like to say that these answers really helps alot! Even after I read this I probably used 10-15 min wanting to run head first into a wall, until it just works! And you figure out what you hae been skipping everytime.

Thanks alot!