Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript and the DOM (Retiring) Getting a Handle on the DOM Practice Selecting Elements

Gawel Konefeld
Gawel Konefeld
2,307 Points
Posted by Gawel Konefeld
Gawel Konefeld
2,307 Points

Proper method for selecting html elements in specific html element

What is wrong if i looking for elements <li> in element nav using command: document.querySelectorAll('nav li')?

js/app.js 
let navigationLinks = document.getElementsByTagName('li');
let galleryLinks;
let footerImages;
index.html 
<!DOCTYPE html>
<html>
  <head>
    <meta charset="utf-8">
    <title>Nick Pettit | Designer</title>
    <link rel="stylesheet" href="css/normalize.css">
    <link href='http://fonts.googleapis.com/css?family=Changa+One|Open+Sans:400italic,700italic,400,700,800' rel='stylesheet' type='text/css'>
    <link rel="stylesheet" href="css/main.css">
    <link rel="stylesheet" href="css/responsive.css">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
  </head>
  <body>
    <header>
      <a href="index.html" id="logo">
        <h1>Nick Pettit</h1>
        <h2>Designer</h2>
      </a>
      <nav>
        <ul>
          <li><a href="index.html" class="selected">Portfolio</a></li>
          <li><a href="about.html">About</a></li>
          <li><a href="contact.html">Contact</a></li>
        </ul>
      </nav>
    </header>
    <div id="wrapper">
      <section>
        <ul id="gallery">
          <li>
            <a href="img/numbers-01.jpg">
              <img src="img/numbers-01.jpg" alt="">
              <p>Experimentation with color and texture.</p>
            </a>
          </li>
          <li>
            <a href="img/numbers-02.jpg">
              <img src="img/numbers-02.jpg" alt="">
              <p>Playing with blending modes in Photoshop.</p>
            </a>
          </li>
        </ul>
      </section>
      <footer>
        <a href="http://twitter.com/nickrp"><img src="img/twitter-wrap.png" alt="Twitter Logo" class="social-icon"></a>
        <a href="http://facebook.com/nickpettit"><img src="img/facebook-wrap.png" alt="Facebook Logo" class="social-icon"></a>
        <p>&copy; 2016 Nick Pettit.</p>
      </footer>
    </div>
  <script src="js/app.js"></script>
  </body>
</html>

1 Answer

silvercoder
silvercoder
11,113 Points

Hi Gawel:

What is wrong if i looking for elements <li> in element nav using command: document.querySelectorAll('nav li')?

That selector would select all the li elements nested within the nav tag but for part 1 of the challenge, you are looking to select the links, see below.

Part 1:

In the following tasks you'll be required to select various elements on the index.html page. In the app.js file on line 1, select all links in the nav element and assign them to navigation Links.

So in the first part you are selecting the links, the 'a' elements.

let navigationLinks = document.querySelectorAll('nav a');

Part 2:

On line 2 of app.js, select all links in the unordered list with the id of "gallery" and assign them to galleryLinks.

Again you're asked to select the links within the tag gallery, so:

let galleryLinks    = document.querySelectorAll('#gallery a');

Part3:

On line 3 of app.js, select all images in the footer element and assign them to footerImages.

Here you are selecting the img tags within the footer tag.

let footerImages    = document.querySelectorAll('footer img');

Hope this helps.