Welcome to the Treehouse Community
Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.
Looking to learn something new?
Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.
Start your free trialKevin Scully
6,506 PointsOnListItemClick Not Working
Hi everyone. I'm having trouble getting OnItemClickListener to work. My code seems to be correct and I get no errors, but nothing happens with a list item is tapped on. Here's my DailyForecastActivity code:
import android.app.Activity;
import android.content.Intent;
import android.os.Bundle;
import android.os.Parcelable;
import android.util.Log;
import android.view.View;
import android.widget.AdapterView;
import android.widget.ListView;
import android.widget.TextView;
import android.widget.Toast;
import com.treehouseapps.stormy.R;
import com.treehouseapps.stormy.adapters.DayAdapter;
import com.treehouseapps.stormy.weather.Day;
import java.util.Arrays;
import butterknife.Bind;
import butterknife.ButterKnife;
public class DailyForecastActivity extends Activity {
private Day[] mDays;
@Bind(android.R.id.list) ListView mListView;
@Bind(android.R.id.empty) TextView mEmptyTextView;
@Override
protected void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
setContentView(R.layout.activity_daily_forecast);
ButterKnife.bind(this);
Intent intent = getIntent();
Parcelable[] parcelables = intent.getParcelableArrayExtra(MainActivity.DAILY_FORECAST);
mDays = Arrays.copyOf(parcelables, parcelables.length, Day[].class);
DayAdapter adapter = new DayAdapter(this, mDays);
mListView.setAdapter(adapter);
mListView.setEmptyView(mEmptyTextView);
mListView.setOnItemClickListener(new AdapterView.OnItemClickListener() {
@Override
public void onItemClick(AdapterView<?> parent, View view, int position, long id) {
String dayOfTheWeek = mDays[position].getDayOfTheWeek();
String conditions = mDays[position].getSummary();
String highTemp = mDays[position].getTemperatureMax() + "";
String message = String.format("On %s the high will be %s and it will be %s", dayOfTheWeek, highTemp, conditions);
Toast.makeText(DailyForecastActivity.this, message, Toast.LENGTH_LONG).show();
}
});
}
}
Same problem in the previous step when DailyForecastActivity extended ListView and we overrode the OnListItemClick method. Any ideas?
Emily Conroyd
6,512 PointsEmily Conroyd
6,512 PointsYou might not need to set the empty text view or call the setOnItemClickListener() now. We are using on ListItemClick() instead. Happy Coding. May the Force be with you.