Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Objects Delivering the MVP Applying a Discount Code

Joash Muganda
Joash Muganda
9,497 Points

normalizeDiscountCode method

I keep getting the message "Hmmm...I ran order.applyDiscountCode("h1!") and I expected it to throw an IllegalArgumentException, but it didn't" when I run this code." Any help please?

I tried my code on BlueJ and it worked.

Order.java
public class Order {
  private String itemName;
  private int priceInCents;
  private String discountCode;

  public Order(String itemName, int priceInCents) {
    this.itemName = itemName;
    this.priceInCents = priceInCents;
  }

  public String getItemName() {
    return itemName;
  }

  public int getPriceInCents() {
    return priceInCents;
  }

  public String getDiscountCode() {
    return discountCode;
  }

  public void applyDiscountCode(String discountCode) {
   try{
     this.discountCode = normalizeDiscountCode(discountCode);
      }
    catch (IllegalArgumentException iae){
      System.out.println(iae.getMessage());
    }
  }
  private String normalizeDiscountCode(String discountCode ){
   for (char ch:discountCode.toCharArray())
 {
    if (!Character.isLetter(ch) && ch!='$')
 {
   throw new IllegalArgumentException("Invalid discount code"); 
      }
    }
return discountCode.toUpperCase(); 
  }

}
Example.java
public class Example {

  public static void main(String[] args) {
    // This is here just for example use cases.

    Order order = new Order(
            "Yoda PEZ Dispenser",
            600);

    // These are valid.  They are letters and the $ character only
    order.applyDiscountCode("abc");
    order.getDiscountCode(); // ABC

    order.applyDiscountCode("$ale");
    order.getDiscountCode(); // $ALE


    try {
      // This will throw an exception because it contains numbers
      order.applyDiscountCode("ABC123");
    } catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }
    try {
      // This will throw as well, because it contains a symbol.
      order.applyDiscountCode("w@w");
    }catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }

  }
}

2 Answers

Tyler B
Tyler B
5,787 Points

So I believe the issue is that you are wrapping your normalizeDiscountCode call in the applyDiscountCode method in a try catch when it's suppose to be letting the exception bubble up.

Joash Muganda
Joash Muganda
9,497 Points

This worked. Thanks!

Cole Baker
Cole Baker
631 Points

I came with a similar question. I got my code to work, it's very similar to yours. If you're still not passing the challenge, maybe try indenting the curly braces correctly for the for loop and the if statement inside of it.