Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Objects Delivering the MVP Applying a Discount Code

Anubhav Chhabra
Anubhav Chhabra
1,383 Points

normalization and validation

i am not getting how to make the condition for this question

Order.java
public class Order {
  private String itemName;
  private int priceInCents;
  private String discountCode;

  public Order(String itemName, int priceInCents) {
    this.itemName = itemName;
    this.priceInCents = priceInCents;
  }

  private String normalizeDiscountCode( String discountCode)
  {

    if( ! discountCode.contains(
    return discountCode.toUpperCase();


  }

  public String getItemName() {
    return itemName;
  }

  public int getPriceInCents() {
    return priceInCents;
  }

  public String getDiscountCode() {
    return discountCode;
  }

  public void applyDiscountCode(String discountCode) {
    this.discountCode = normalizeDiscountCode( discountCode);
  }
}
Example.java
public class Example {

  public static void main(String[] args) {
    // This is here just for example use cases.

    Order order = new Order(
            "Yoda PEZ Dispenser",
            600);

    // These are valid.  They are letters and the $ character only
    order.applyDiscountCode("abc");
    order.getDiscountCode(); // ABC

    order.applyDiscountCode("$ale");
    order.getDiscountCode(); // $ALE


    try {
      // This will throw an exception because it contains numbers
      order.applyDiscountCode("ABC123");
    } catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }
    try {
      // This will throw as well, because it contains a symbol.
      order.applyDiscountCode("w@w");
    }catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }

  }
}

2 Answers

Alex Bratkovskij
Alex Bratkovskij
5,329 Points
   private String normalizeDiscountCode(String discountCode) {

    for( char letter : discountCode.toCharArray()) {
      if(! (Character.isLetter(letter) || letter == '$')) {
        throw new IllegalArgumentException("Invalid discount code");
      }
    }
    return discountCode.toUpperCase();
   }

The way to read it :

Method that returns string called normalizeDiscountCode that takes string discountCode as an argument, check each character in discountCode and if character is not a letter nor a symbol $, throw IAE, if it is, return discountCode with upper casing.

-Alex

Anubhav Chhabra
Anubhav Chhabra
1,383 Points

ooohhhh got it ..... i was using the exclamation mark in just first case ..... thanks bro;

Alex Bratkovskij
Alex Bratkovskij
5,329 Points

Hey there Anubhav,

Now second task asks you to make sure that string is made of characters and starts with '$' sign. So let me walk you through a logic I was following when I was making a code, and then you try and follow it and make it in code, K? :)

You want to get through EACH character in discountCode, then for each character, you want to check if this Character isLetter, or if it is a '$' character. But, there is a twist, if they enter a discount code that doesnt apply to these rules, we want to prompt them with IllegalArgumentException saying that this is invalid. So we nneed to reverse our logic.

For each character in discountCode I want to check if it is NOT(!) a letter nor it is a '$' .

If you need a hand with the code itself, give us a poke and we can walk through finished code and see where is the issue that u dont understand ;)

Good luck!

-Alex

Anubhav Chhabra
Anubhav Chhabra
1,383 Points

bro please help writing the code

thanks