Made a Quiz! Can someone review my code?

Excellent job! (Though I have no idea what these questions or answers are saying!)

I would make two very minor suggestions:

Replace this code:

  if (userAnswer.toLowerCase() === quizQuestions [i][1]) {
    correctAnswer.push (true);
  } else {
    correctAnswer.push (false);
  }  

...with this line:

  correctAnswer [i] = userAnswer.toLowerCase() === quizQuestions [i][1];

This not only makes the code a bit more compact, but the use of subscripting is consistent with the way the list is handled later. Mixing "push" with subscripts can potentially cause trouble if future code changes are made.

My other suggestion is to replace this very long line:

var html = "<p>You got " + numberCorrectAnswers + " question(s) right.</p><h2>You got these questions correct:</h2><ol>" + correctList + "</ol><h2>You got these questions wrong:</h2><ol>" + wrongList + "</ol>";

...with these lines:

var html = "<p>You got " + numberCorrectAnswers
         + " question(s) right.</p><h2>You got these questions correct:</h2><ol>"
         + correctList
         + "</ol><h2>You got these questions wrong:</h2><ol>"
         + wrongList + "</ol>";

And that's simply to enhance readability.

Keep up the good work, and happy coding!   -sp

I agree - great work! :)

I have some suggestions though (I'll post the code at the end this);

• You have a 2D array where index 0 is question, and 1 is answer. I would recommend changing the structure to an object
• Make functions for repetitive tasks. Right now you have one function that writes the output, once. No need for a function for that.
• You can easily avoid the if/else in your first loop, and write it much cleaner (see code below).
• When declaring multiple variables, you don't need 'var' on every line, just comma-separate them (this is just personal preference)
• You have two loops, one where you store the correct/false answers, and one for making the correct/wrong lists. This could be done in one loop, I don't include this in my code below though

var quizQuestions = [
    { question: 'Wat is mijn voornaam?', answer: 'martijn' },
    { question: 'Wat is mijn achternaam?', answer: 'brackman' },
    { question: 'Wat is de naam van mijn bedrijf?', answer: 'skroll' }
];

var correctAnswer = [],     // Array to store whether the answer was correct or not.
    correctList = "",       // Storing all correct questions.
    wrongList = "";         // Storing all wrong questions.



quizQuestions.forEach(function(obj) {
    var userAnswer = prompt(obj.question),
        result = userAnswer.toLowerCase() === obj.answer; //This will evaluate to either true or false, which means you can just store the result

    correctAnswer.push(result);
});


correctAnswer.forEach(function(answer, i) {
    if(answer === false)    wrongList += "<li>" + quizQuestions[i].question + "</li>";
    else                    correctList += "<li>" + quizQuestions[i].question + "</li>";            
});


// Putting together message
var html = "<p>You got " + correctList.length + " question(s) right.</p><h2>You got these questions correct:</h2><ol>" + correctList + "</ol><h2>You got these questions wrong:</h2><ol>" + wrongList + "</ol>";


// Printing the result
document.write(html);

Hi Steven

Just te be sure about this line of code:

  correctAnswer [i] = userAnswer.toLowerCase() === quizQuestions [i][1];

Is it correct when I say Javascript automatically sees this as true or false? And is "true" or "false" what is pushed to my array? So it is correct to assume that I get the same result as I was trying to achieve with "correctAnswer.push"?

I only started learning JavaScript a couple of days ago so I have a lot to find out. Thank you very much for the reply.

Here is my code: https://w.trhou.se/9ui822ziu2