Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript and the DOM (Retiring) Getting a Handle on the DOM Selecting Multiple Elements

Posted by rygelzwruy
rygelzwruy
7,931 Points

JavaScript selectors (DOM) need help ^^

I just don't get it, it keeps saying: "There should be 7 list items"

index.html 
<!DOCTYPE html>
<html>
  <head>
    <title>Rainbow!</title>
  </head>
  <body>
    <ul id="rainbow">
      <li>This should be red</li>
      <li>This should be orange</li>
      <li>This should be yellow</li>
      <li>This should be green</li>
      <li>This should be blue</li>
      <li>This should be indigo</li>
      <li>This should be violet</li>
    </ul>
    <script src="js/app.js"></script>
  </body>
</html>
js/app.js 
let listItems = document.querySelectorAll('rainbow');
const colors = ["#C2272D", "#F8931F", "#FFFF01", "#009245", "#0193D9", "#0C04ED", "#612F90"];

for(var i = 0; i < rainbow.length; i ++) {
  rainbow[i].style.color = colors[i];    
}

1 Answer

Jennifer Nordell
seal-mask
STAFF
.a{fill-rule:evenodd;}techdegree
Jennifer Nordell
Treehouse Teacher
Jennifer Nordell
.a{fill-rule:evenodd;}techdegree
Jennifer Nordell
Treehouse Teacher

Hi there! There are a couple of things going on here. First, let's take a look at your selector. You're selecting all things that contain "rainbow". But there is only one item that contains rainbow and that's the <ul> (unordered list) element. You want to be selecting the collection of <li> that reside inside of "rainbow". So something like ("rainbow li") would work. Actually, you could do something even simpler here because they are the only list items on the page, you could simply select ("li") and that would work too!

Secondly, your syntax is spot on for the for loop, but you're attempting to loop over a variable named rainbow which is not defined. This was the purpose of making the listItems variable. You should be looping over listItems instead of rainbow.

Hope this helps! :sparkles:

rygelzwruy
rygelzwruy
7,931 Points

Thanks I got it ! :D