Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Local Development Environments Advanced Tooling Finishing TreeStory

java.long.OutOfMemoryError

Exception in thread "main" java.lang.OutOfMemoryError: Java heap space at com.teamtreehouse.Prompter.promptForWord(Prompter.java:73) at com.teamtreehouse.Prompter.promptForWords(Prompter.java:57) at com.teamtreehouse.Prompter.run(Prompter.java:38) at com.teamtreehouse.Main.main(Main.java:12) at JavaTester.run(JavaTester.java:77) at JavaTester.main(JavaTester.java:39)

why I got an OutOfMemoryError in the web page test and run without any problem at my local PC ? In my code, I have already initiated a null string to the new respond in the Prompter.promptForWord(Prompter.java:71).....

com/teamtreehouse/Main.java
package com.teamtreehouse;


public class Main {

    public static void main(String[] args) {
    // write your code here

        Prompter prompter = new Prompter();
        String story = "Thanks __name__ for helping me out.  You are really a __adjective__ __noun__ and I owe you a __noun__.";
        Template tmpl = new Template(story);
        prompter.run(tmpl);

    }
}
com/teamtreehouse/Prompter.java
package com.teamtreehouse;

import java.io.*;
import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.Paths;
import java.util.ArrayList;
import java.util.HashSet;
import java.util.List;
import java.util.Set;


public class Prompter {
    private BufferedReader mReader;
    private Set<String> mCensoredWords;

    public Prompter() {
        mReader = new BufferedReader(new InputStreamReader(System.in));
        loadCensoredWords();
    }

    private void loadCensoredWords() {
        mCensoredWords = new HashSet<String>();
        Path file = Paths.get("resources", "censored_words.txt");
        List<String> words = null;
        try {
            words = Files.readAllLines(file);
        } catch (IOException e) {
            System.out.println("Couldn't load censored words");
            e.printStackTrace();
        }
        mCensoredWords.addAll(words);
    }

    public void run(Template tmpl) {
        List<String> results = null;
        try {
            results = promptForWords(tmpl);
        } catch (IOException e) {
            System.out.println("There was a problem prompting for words");
            e.printStackTrace();
            System.exit(0);
        }
        System.out.println(tmpl.render(results));
    }

    /**
     * Prompts user for each of the blanks
     *
     * @param tmpl The compiled template
     * @return
     * @throws IOException
     */
    public List<String> promptForWords(Template tmpl) throws IOException {
        List<String> words = new ArrayList<String>();
        for (String phrase : tmpl.getPlaceHolders()) {
            String word = promptForWord(phrase);
            words.add(word);
        }
        return words;
    }


    /**
     * Prompts the user for the answer to the fill in the blank.  Value is guaranteed to be not in the censored words list.
     *
     * @param phrase The word that the user should be prompted.  eg: adjective, proper noun, name
     * @return What the user responded
     */
    public String promptForWord(String phrase) throws IOException {
        String respond = "";
        do {
            System.out.printf("What do you want to describe %s.", phrase);
            respond = mReader.readLine();
        } while ( !mCensoredWords.contains(respond));
        return respond;
    }
}
pseudo-tests.md
#  This is essentially what I am testing 
1.  The user is prompted for a new string template (the one with the double underscores in it).

  a. The prompter class has a new method that prompts for the story template, and that method is called.

2.  The user is then prompted for each word that has been double underscored.

   a. The answer is checked to see if it is contained in the censored words.
      User is continually prompted until they enter a valid word

3.  The user is presented with the completed story

1 Answer

Benjamin Barslev Nielsen
Benjamin Barslev Nielsen
18,958 Points

Line 75 in prompter.js

} while ( !mCensoredWords.contains(respond));

should be

} while ( mCensoredWords.contains(respond));

You want to keep prompting the user until the user picks a uncensored word, and therefore the loop should continue as long as respond is a censored word.

Why OutOfMemoryError: Treehouse probably have a test that keeps answering with a uncensored word, and this makes your program loop forever. They probably also stores all the output from System.out.printf in memory, such that they can analyze it to check for a correct solution. Therefore when System.out.printf is called infinitely, the memory usage increases and at some point it raises a OutOfMemoryError.

Thank you so much Benjamin. It helps a lot. I often consider the requirement in the wrong way, just like that, I think the word should be contained in the censored set...