Welcome to the Treehouse Community
Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.
Looking to learn something new?
Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.
Start your free trialNibin Mathews
Courses Plus Student 2,073 PointsJava Objects - Delivery the MVP - Applying a discount code - Task 2 of 2
Could someone let me know what could be the issue with the code i have in here ? I am getting the following message when i check the work. Bummer! Hmmm...I ran order.applyDiscountCode("h1!") and I expected it to throw an IllegalArgumentException, but it didn't
I tried the condition check discountCode.matches("^[a-zA-Z$]+") after assigning discountCode="h1!"; through jshell and I got the value returned as false. Please help
public class Order {
private String itemName;
private int priceInCents;
private String discountCode;
public Order(String itemName, int priceInCents) {
this.itemName = itemName;
this.priceInCents = priceInCents;
}
public String getItemName() {
return itemName;
}
public int getPriceInCents() {
return priceInCents;
}
public String getDiscountCode() {
return discountCode;
}
public void applyDiscountCode(String discountCode) {
try{
this.discountCode = normalizeDiscountCode(discountCode);
}catch(IllegalArgumentException iae){
System.out.println(iae.getMessage());
}
}
private String normalizeDiscountCode(String discountCode){
if(!discountCode.matches("^[a-zA-Z$]+")){
throw new IllegalArgumentException("Invalid discount code");
}
return discountCode.toUpperCase();
}
}
public class Example {
public static void main(String[] args) {
// This is here just for example use cases.
Order order = new Order(
"Yoda PEZ Dispenser",
600);
// These are valid. They are letters and the $ character only
order.applyDiscountCode("abc");
order.getDiscountCode(); // ABC
order.applyDiscountCode("$ale");
order.getDiscountCode(); // $ALE
try {
// This will throw an exception because it contains numbers
order.applyDiscountCode("ABC123");
} catch (IllegalArgumentException iae) {
System.out.println(iae.getMessage()); // Prints "Invalid discount code"
}
try {
// This will throw as well, because it contains a symbol.
order.applyDiscountCode("w@w");
}catch (IllegalArgumentException iae) {
System.out.println(iae.getMessage()); // Prints "Invalid discount code"
}
}
}
2 Answers
Seth Kroger
56,414 PointsAlright, I see the issue is you are catching the exception in the applyDiscountCode() method and not letting it fall through to the calling code.