Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript and the DOM (Retiring) Getting a Handle on the DOM Selecting by Id

Posted by Kiara Stewart
Kiara Stewart
4,283 Points

I've selected the id (document.getElementById('sayPhrase'); How do I assign it correctly?

document.getElementById('sayPhrase'); is inside the event listener. Do I need to take it out?

js/app.js 
var button;
var input;

button.addEventListener('click', () => {
  alert(input.value);
  document.getElementById('sayPhrase');
});
index.html 
<!DOCTYPE html>
<html>
  <head>
    <title>Phrase Sayer</title>
  </head>
  <body>
    <p><input type="text" id="phraseText"></p>
    <p><button id="sayPhrase">Say Phrase</button></p>
    <script src="js/app.js"></script>
  </body>
</html>

1 Answer

Jose Lievano
Jose Lievano
4,909 Points
Jose Lievano
Jose Lievano
4,909 Points

Yeah, but added the "document.getElementById('sayPhrase');" inside the function, when the function execute, the button var should already be set.

This way: 

var button  = document.getElementById("sayPhrase");
var input;

button.addEventListener('click', () => {  
  alert(input.value);
});