Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Android Build a Simple Android App Basic Android Programming Choosing a Random Fact

Posted by hema rajan
hema rajan
Courses Plus Student 465 Points

is that good to declare instance of an class inside OnclickListener?

if I declared Random instance and the Facts array inside the OnclickListener, every time user tap on that button, it's going to be re-instantiate. Is that good?

1 Answer

erikanoemiorozco
erikanoemiorozco
1,318 Points
erikanoemiorozco
erikanoemiorozco
1,318 Points

That is not recommended because that instance is going to be created each time the user clicks the button and that will take lot of memory, try to do the instance at the top of the class and just call it in your onClick.

Hope it helps!