Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript and the DOM (Retiring) Getting a Handle on the DOM Selecting Multiple Elements

Posted by timothy hawley
timothy hawley
285 Points

im stuck

i don't know what part of the code is wrong

index.html 
<!DOCTYPE html>
<html>
  <head>
    <title>Rainbow!</title>
  </head>
  <body>
    <ul id="rainbow">
      <li>This should be red</li>
      <li>This should be orange</li>
      <li>This should be yellow</li>
      <li>This should be green</li>
      <li>This should be blue</li>
      <li>This should be indigo</li>
      <li>This should be violet</li>
    </ul>
    <script src="js/app.js"></script>
  </body>
</html>
js/app.js 
var listItems = document.getElementById('ul');
const colors = ["#C2272D", "#F8931F", "#FFFF01", "#009245", "#0193D9", "#0C04ED", "#612F90"];

for(var i = 0; i < colors.length; i ++) {
  listItems[i].style.color = colors[i];    
}

2 Answers

Regan O'Neill
Regan O'Neill
12,714 Points
Regan O'Neill
Regan O'Neill
12,714 Points

'ul' isn't an id, it's an element. You should try grabbing 'rainbow' instead.

Redweb FED
Redweb FED
15,517 Points
Redweb FED
Redweb FED
15,517 Points

Hey, Tim

Following on for Regan's suggestion will put you in the right direction and give you this.

var listItems = document.getElementById('rainbow');

However there is still one more thing your missing as using the value above will only because you are returning the ul element and not the collection of li's which is what you want to style. to do that you want to return the children of the parent ul like so.

var listItems = document.getElementById('rainbow').children;

The rest of your code is fine as you can see here. http://codepen.io/Adam_Rusty/pen/dNOpzL