Welcome to the Treehouse Community
Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.
Looking to learn something new?
Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.
Start your free trialAndrew Gursky
12,576 PointsI tested this in my terminal and it worked? Why won't it pass?
Am I misunderstanding the challenge?
class Letter:
def __init__(self, pattern=None):
self.pattern = pattern
def __iter__(self):
yield from self.pattern
def __str__(self):
output = []
for blip in self:
if blip == '.':
output.append('dot')
else:
output.append('dash')
return '-'.join(output)
@classmethod
def from_string(cls, string):
newList = string.rsplit('-')
newStrList = []
for item in newList:
if item == 'dot':
newStrList.append('.')
elif item == 'dash':
newStrList.append('-')
return (Letter(newStrList))
class S(Letter):
def __init__(self):
pattern = ['.', '.', '.']
super().__init__(pattern)
2 Answers
Chris Freeman
Treehouse Moderator 68,454 PointsYou are SO close! The "dash" should be replaced with an underscore ("_") not a hypen ("-").
Also,
-
rsplit
is not necessary, usesplit
instead.rsplit
behaves exactly likesplit
if the maxsplit argument is not given. - The improved return statement would be
cls(newStrList)
. This is because you are not repeating the class name. If the class is renamed, then the code would not needed to be search for literal uses of "Letter".
Andrew Gursky
12,576 PointsThanks again Chris!