Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript and the DOM (Retiring) Traversing the DOM Getting All Children of a Node with children

Posted by Sajid Patel
Sajid Patel
183 Points

i need help

const toggleList = document.getElementById("toggleList"); const listDiv = document.querySelector(".list"); const listUl = listDiv.querySelector("ul"); const descriptionInput = document.querySelector("input.description"); const descriptionP = document.querySelector("p.description"); const descriptionButton = document.querySelector("button.description"); const addItemInput = document.querySelector("input.addItemInput"); const addItemButton = document.querySelector("button.addItemButton"); const lis = listUl.children;

function attachListItemButtons(li) { let up = document.createElement("button"); up.classname = "up"; up.textContent = "Up"; li.appendChild(up);

let down = document.createElement("button"); down.classname = "down"; down.textContent = "Down"; li.appendChild(down);

let remove = document.createElement("button"); remove.classname = "remove"; remove.textContent = "Remove"; li.appendChild(remove); }

for (let i = 0; i < li.length; i++) { addListItemButtons(lis[li]); }

listUl.addEventListener("click", (event) => { if (event.target.tagName == "BUTTON") { if (event.target.className == "remove") { let li = event.target.parentNode; let ul = li.parentNode; ul.removeChild(li); } if (event.target.className == "up") { let li = event.target.parentNode; let prevLi = li.previousElementSibling; let ul = li.parentNode; if (prevLi) { ul.insertBefore(li, prevLi); } } if (event.target.className == "down") { let li = event.target.parentNode; let nextLi = li.nextElementSibling; let ul = li.parentNode; if (nextLi) { ul.insertBefore(nextLi, li); } } } });

toggleList.addEventListener("click", () => { if (listDiv.style.display == "none") { toggleList.textContent = "Hide list"; listDiv.style.display = "block"; } else { toggleList.textContent = "Show list"; listDiv.style.display = "none"; } });

descriptionButton.addEventListener("click", () => { descriptionP.innerHTML = descriptionInput.value + ":"; descriptionInput.value = ""; });

addItemButton.addEventListener("click", () => { let ul = document.getElementsByTagName("ul")[0]; let li = document.createElement("li"); li.textContent = addItemInput.value; addListItemButtons(li); ul.appendChild(li); addItemInput.value = ""; });

AND THE HTML IS

<!DOCTYPE html> <html> <head> <title>JavaScript and the DOM</title> <link rel="stylesheet" href="css/style.css" /> </head> <body> <h1 id="myHeading">JavaScript and the DOM</h1> <p>Making a web page interactive</p> <button id="toggleList">Hide list</button> <div class="list"> <p class="description">Things that are purple:</p> <input type="text" class="description" /> <button class="description">Change list description</button> <ul> <li> grapes </li> <li> amethyst </li> <li> lavender </li> <li> plums </li> </ul> <input type="text" class="addItemInput" /> <button class="addItemButton">Add item</button> </div> <script src="app.js"></script> </body> </html>

1 Answer

James Croxford
James Croxford
12,723 Points
James Croxford
James Croxford
12,723 Points

Hi Sajid,

I'm not sure if what you need help with specifically, but I assume you mean that your code just isn't working? I've gone through it for you and found some mistakes- don't forget to mark up your code to make it easier to read for others! Code

Wrap your code with 3 backticks (```) on the line before and after. If you specify the language after the first set of backticks, that'll help us with syntax highlighting.

      ```javascript //just type three backticks followed by the language name like this.
      <p>This is code!</p>
      ``` //another three backticks

const toggleList = document.getElementById("toggleList"); 
const listDiv = document.querySelector(".list"); 
const listUl = listDiv.querySelector("ul"); 
const descriptionInput = document.querySelector("input.description"); 
const descriptionP = document.querySelector("p.description"); 
const descriptionButton = document.querySelector("button.description"); 
const addItemInput = document.querySelector("input.addItemInput"); 
const addItemButton = document.querySelector("button.addItemButton"); 
const lis = listUl.children;

//the className property isn't capitalised in the function below
function attachListItemButtons(li) { 
  let up = document.createElement("button"); 
  up.classname = "up"; 
  up.textContent = "Up"; 
  li.appendChild(up);

let down = document.createElement("button"); 
  down.classname = "down"; 
  down.textContent = "Down"; 
  li.appendChild(down);

let remove = document.createElement("button"); 
  remove.classname = "remove"; 
  remove.textContent = "Remove"; 
  li.appendChild(remove); 
}

//for loop: look at the length condition- you've typed li instead of 'lis'
for (let i = 0; i < li.length; i++) { 
  addListItemButtons(lis[li]); 
}

listUl.addEventListener("click", (event) => {
  if (event.target.tagName == "BUTTON") { 
    if (event.target.className == "remove") {
      let li = event.target.parentNode; 
      let ul = li.parentNode; 
      ul.removeChild(li); 
    } 
    if (event.target.className == "up") {
      let li = event.target.parentNode; 
      let prevLi = li.previousElementSibling; 
      let ul = li.parentNode; 
      if (prevLi) { 
        ul.insertBefore(li, prevLi); 
      } 
    } 
    if (event.target.className == "down") { 
      let li = event.target.parentNode; 
      let nextLi = li.nextElementSibling; 
      let ul = li.parentNode; 
      if (nextLi) { 
        ul.insertBefore(nextLi, li); 
      } 
    } 
  } 
});

toggleList.addEventListener("click", () => {
   if (listDiv.style.display == "none") { 
  toggleList.textContent = "Hide list"; 
  listDiv.style.display = "block"; 
} else { 
  toggleList.textContent = "Show list"; listDiv.style.display = "none"; 
} 
});

descriptionButton.addEventListener("click", () => {
  descriptionP.innerHTML = descriptionInput.value + ":"; descriptionInput.value = ""; 
});


addItemButton.addEventListener("click", () => { 
  let ul = document.getElementsByTagName("ul")[0]; 
  let li = document.createElement("li"); 
  li.textContent = addItemInput.value; 
//the line below calling a function is misspelt.
  addListItemButtons(li); 
  ul.appendChild(li); 
  addItemInput.value = ""; 
});

I've not checked the HTML, and there might be a few more in the app.js file, but it looks to just be a few typos causing you problems.