Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript and the DOM (Retiring) Getting a Handle on the DOM Selecting Multiple Elements

Posted by Shannon Booker
.a{fill-rule:evenodd;}techdegree
Shannon Booker
Full Stack JavaScript Techdegree Student 2,391 Points

I dont understand how to complete this

should i be using querySelector?

js/app.js 
var listItems = document.qetElementById('rainbow');
var colors = ["#C2272D", "#F8931F", "#FFFF01", "#009245", "#0193D9", "#0C04ED", "#612F90"];

for(var i = 0; i < colors.length; i ++) {
  listItems[i].style.color = colors[i];    
}
index.html 
<!DOCTYPE html>
<html>
  <head>
    <title>Rainbow!</title>
  </head>
  <body>
    <ul id="rainbow">
      <li>This should be red</li>
      <li>This should be orange</li>
      <li>This should be yellow</li>
      <li>This should be green</li>
      <li>This should be blue</li>
      <li>This should be indigo</li>
      <li>This should be violet</li>
    </ul>
    <script src="js/app.js"></script>
  </body>
</html>

1 Answer

Lukas Schmid
Lukas Schmid
7,002 Points
Lukas Schmid
Lukas Schmid
7,002 Points

Hi Shannon,

yes, I would use the query selector.
Right now you are using "getElementbyId", btw there is a small typo in yours ;).
This gives you back only one element. In this case, the element with the id "rainbow"

To be able to use the for loop by looping through a collection of elements, I would use the querySelectorAll, to get a collection of all li elements inside the ul with the id "rainbow"

So that should work:

var listItems = document.querySelectorAll('#rainbow li');