Welcome to the Treehouse Community
Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.
Looking to learn something new?
Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.
Start your free trial
Yamil Pérez
Courses Plus Student 2,054 PointsI am not sure what is wrong with my code. I need some help on this challegen
I think my code is with I can't find the error guys
public class Order {
private String itemName;
private int priceInCents;
private String discountCode;
public Order(String itemName, int priceInCents) {
this.itemName = itemName;
this.priceInCents = priceInCents;
}
public String getItemName() {
return itemName;
}
public int getPriceInCents() {
return priceInCents;
}
public String getDiscountCode() {
return discountCode;
}
public void applyDiscountCode(String discountCode) {
this.discountCode = normalizeDiscountCode(discountCode);
}
private String normalizeDiscountCode(String discountCode){
i(!Character.isDiscountCode(discountCode) || discountCode =='$'){
throw new IllegalArgumentException("Invalid discount code.");
}
return discountCode.toUpperCase();
}
}
public class Example {
public static void main(String[] args) {
// This is here just for example use cases.
Order order = new Order(
"Yoda PEZ Dispenser",
600);
// These are valid. They are letters and the $ character only
order.applyDiscountCode("abc");
order.getDiscountCode(); // ABC
order.applyDiscountCode("$ale");
order.getDiscountCode(); // $ALE
try {
// This will throw an exception because it contains numbers
order.applyDiscountCode("ABC123");
} catch (IllegalArgumentException iae) {
System.out.println(iae.getMessage()); // Prints "Invalid discount code"
}
try {
// This will throw as well, because it contains a symbol.
order.applyDiscountCode("w@w");
}catch (IllegalArgumentException iae) {
System.out.println(iae.getMessage()); // Prints "Invalid discount code"
}
}
}
3 Answers
Lauren Moineau
9,483 PointsHi Yamil. I'll add some explanation to the code Marie Franklin posted. Let's have a look at the instructions: "Only letters and the $ symbols are allowed in the discount code. (...) If any other character is used, throw an IllegalArgumentException with the message "Invalid discount code"."
So, it means:
- if our
discountCodecontains anything other than letters and '$', we'll throw an exception - else, we'll return
discountCodein uppercase.
Right now, discountCode is a string and $ is a char and in order to compare them, they would need to be of the same type. So we would need to transform our discountCode into an array of char first, so we could loop through it to check if they're all letters or '$'.
private String normalizeDiscountCode(String discountCode){
for (char letter : discountCode.toCharArray()) { // for each letter in our char array (from our `discountCode` string)
if (!Character.isLetter(letter) && letter != '$') { // if the letter is not a letter AND is not a $
throw new IllegalArgumentException("Invalid discount code."); // throw an exception
}
}
return discountCode.toUpperCase(); // else, return the `discountCode` in uppercase
}
I hope it clarifies things :)
Marie Franklin
13,358 Points private String normalizeDiscountCode(String discountCode){
for(char letter: discountCode.toCharArray()){
if(!Character.isLetter(letter) && letter != 36){
throw new IllegalArgumentException("Invalid discount code.");
}
}
return discountCode.toUpperCase();
}
Yamil Pérez
Courses Plus Student 2,054 PointsThank you Marie
Yamil Pérez
Courses Plus Student 2,054 PointsThanks you
Lauren Moineau
9,483 PointsYou're welcome :)