Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Objects Delivering the MVP Applying a Discount Code

Solomon Asiedu-Ofei Jnr
Solomon Asiedu-Ofei Jnr
1,015 Points

I added a regex tester to validate my string with only alphabets or $ but I am getting an error saying Task 1 is no long

getting an error saying Task 1 is no longer passing

Order.java
import java.io.Console;
import java.util.regex.Pattern;
import java.util.regex.Matcher;

public class Order {
  private String itemName;
  private int priceInCents;
  private String discountCode;
  private String upperCodes;

  private String normalizeDiscountCode(String discountCode) {
    if(discountCode.matches("[a-zA-Z|$]+")){
   throw new IllegalArgumentException("Invalid discount code");
   }

  String upperCodes = discountCode.toUpperCase();
  return upperCodes;
  }

  public Order(String itemName, int priceInCents) {
    this.itemName = itemName;
    this.priceInCents = priceInCents;
  }

  public String getItemName() {
    return itemName;
  }

  public int getPriceInCents() {
    return priceInCents;
  }

  public String getDiscountCode() {
    return discountCode;
  }

  public void applyDiscountCode(String discountCode) {
    this.discountCode = normalizeDiscountCode(discountCode);
  }
}
Example.java
public class Example {

  public static void main(String[] args) {
    // This is here just for example use cases.

    Order order = new Order(
            "Yoda PEZ Dispenser",
            600);

    // These are valid.  They are letters and the $ character only
    order.applyDiscountCode("abc");
    order.getDiscountCode(); // ABC

    order.applyDiscountCode("$ale");
    order.getDiscountCode(); // $ALE


    try {
      // This will throw an exception because it contains numbers
      order.applyDiscountCode("ABC123");
    } catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }
    try {
      // This will throw as well, because it contains a symbol.
      order.applyDiscountCode("w@w");
    }catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }

  }
}

1 Answer

Caleb Kleveter
MOD
Caleb Kleveter
Treehouse Moderator 37,862 Points

Very close. You made one minor error in your normalizeDiscountCode method. You wrote this if-statement:

if(discountCode.matches("[a-zA-Z|$]+")){
   throw new IllegalArgumentException("Invalid discount code");
}

What this code says is: "If the string is only made of alphabetical characters and dollar signs, throw an exception." It should say the opposite: "If the string is not only made of alphabetical characters and dollar signs, throw an exception."

All you have to do to fix this is to add the not operator to the front of your condition:

if(!discountCode.matches("[a-zA-Z|$]+")){
// ^~~~~ Added '!'
   throw new IllegalArgumentException("Invalid discount code");
}