Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript Basics (Retired) Creating Reusable Code with Functions Create a max() Function

Posted by slava vissoki
slava vissoki
Courses Plus Student 1,709 Points

help with task please

hi can somebody help me finish the task please?

script.js 
function max(number1, number2) {
if(number1 > number2 && number1!==number2) {
 var num1 = (number1);
return num1;
}
 if (number2>number1 && number1!==number2) {
   var num2 = (number2);
 return num2;
 } 
max(1,2);
Simon Coates
Simon Coates
28,694 Points

as Dom Talbert observes, you missed a }. I'd note that your code doesn't return anything if the numbers are equal. The following simple example is also accepted (for reference):

function max(number1, number2) {
  if(number1 > number2) {
    return number1;
  } else {
      return number2; 
  }
  //return (number1 > number2)? number1: number2; //ternary alternative
}

1 Answer

Dom Talbot
Dom Talbot
7,686 Points

Hey Slava

Your simply missing a closing bracket :)

function max(number1, number2) {
    if(number1 > number2 && number1!==number2) {
        var num1 = (number1);
        return num1;
    }
    if (number2>number1 && number1!==number2) {
        var num2 = (number2);
        return num2;
    }
} // Missing closing bracket
max(1,2);