Welcome to the Treehouse Community
Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.
Looking to learn something new?
Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.
Start your free trial
Anuj Bhusari
12,240 PointsGives the error Task 1 is no longer passing!
Can someone please check my code and tell me why i am getting the given error above!
public class Order {
private String itemName;
private int priceInCents;
private String discountCode;
public Order(String itemName, int priceInCents) {
this.itemName = itemName;
this.priceInCents = priceInCents;
}
public String getItemName() {
return itemName;
}
public int getPriceInCents() {
return priceInCents;
}
public String getDiscountCode() {
return discountCode;
}
public void applyDiscountCode(String discountCode) {
this.discountCode = normalizeDiscountCode(discountCode);
}
private String normalizeDiscountCode(String discountCode){
discountCode = discountCode.toUpperCase();
char[] codeLength = discountCode.toCharArray();
for(int i=0; i<codeLength.length; i++){
char letter = discountCode.charAt(i);
if(!Character.isLetter(letter) || letter != '$'){
throw new IllegalArgumentException("Invalid discount code");
}
}
return discountCode;
}
}
public class Example {
public static void main(String[] args) {
// This is here just for example use cases.
Order order = new Order(
"Yoda PEZ Dispenser",
600);
// These are valid. They are letters and the $ character only
order.applyDiscountCode("abc");
order.getDiscountCode(); // ABC
order.applyDiscountCode("$ale");
order.getDiscountCode(); // $ALE
try {
// This will throw an exception because it contains numbers
order.applyDiscountCode("ABC123");
} catch (IllegalArgumentException iae) {
System.out.println(iae.getMessage()); // Prints "Invalid discount code"
}
try {
// This will throw as well, because it contains a symbol.
order.applyDiscountCode("w@w");
}catch (IllegalArgumentException iae) {
System.out.println(iae.getMessage()); // Prints "Invalid discount code"
}
}
}
3 Answers
Simon Coates
28,694 Pointsseems okay with:
private String normalizeDiscountCode(String discountCode){
discountCode = discountCode.toUpperCase();
for(char letter: discountCode.toCharArray()){
if(!Character.isLetter(letter) && letter != '$'){//DIFFERENT CONDITION
throw new IllegalArgumentException("Invalid discount code");
}
}
return discountCode;
}
if being a Letter is A and being a $ is B, then the positive condition is A || B. To flip that, you get !A && !B.
Anuj Bhusari
12,240 PointsOn changing the || to && i am getting the following error :- Hmmm...I ran order.applyDiscountCode("h1!") and I expected it to throw an IllegalArgumentException, but it didn't
Simon Coates
28,694 PointsI think you may still be catching the error. You may need to restart the challenge to get rid of unnecessary modifications. I was definitely able to pass using your Order class, but with the above rewritten method.
Darel Bitsy
6,910 Pointshere
private String normalizeDiscountCode(String discountCode){
for(char letter: discountCode.toCharArray()){
if(!Character.isLetter(letter) && letter != '$'){
throw new IllegalArgumentException("Invalid discount code");
}
}
return discountCode.toUpperCase();
}
public void applyDiscountCode(String discountCode) {
this.discountCode = normalizeDiscountCode(discountCode);
}
Darel Bitsy
6,910 PointsTry to remove the try and catch as Simon suggested
Anuj Bhusari
12,240 PointsAnuj Bhusari
12,240 PointsEven after i add the try and catch in the applyDiscountCode it gives me the same error!