Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript and the DOM (Retiring) Getting a Handle on the DOM Practice Selecting Elements

Posted by Steve Olsen
Steve Olsen
1,694 Points

get <li> elements of a <nav> element using js, possible glitch with quiz

im on the DOM section and this is a question for the final quiz of that section.

the challenge is to get 3 list elements (there are 5 in the HTML code) the first thing i tried is to set the variable on line 1 = document.getElementsByTagName('li'); but as we know that will return all 5 and i just wan the first 3. so then i tried = document.getElementsByTagName('li')[0,1,2]; and it wouldnt accept the answer. I then addes a class called 'this' to each of the 3 <li> elements i wanted. surely i'd be able to call them by class now. wrong. =document.getElementsByClassName('this'); gives me nothing. i think its a glitch. any ideas? is it me or should at least one of these methods work?

Steve

js/app.js 
let navigationLinks = document.getElementsByClassName('this');
let galleryLinks;
let footerImages;
index.html 
<!DOCTYPE html>
<html>
  <head>
    <meta charset="utf-8">
    <title>Nick Pettit | Designer</title>
    <link rel="stylesheet" href="css/normalize.css">
    <link href='http://fonts.googleapis.com/css?family=Changa+One|Open+Sans:400italic,700italic,400,700,800' rel='stylesheet' type='text/css'>
    <link rel="stylesheet" href="css/main.css">
    <link rel="stylesheet" href="css/responsive.css">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
  </head>
  <body>
    <header>
      <a href="index.html" id="logo">
        <h1>Nick Pettit</h1>
        <h2>Designer</h2>
      </a>
      <nav>
        <ul>
          <li><a href="index.html" class="selected" class="this">Portfolio</a></li>
          <li><a href="about.html" class="this">About</a></li>
          <li><a href="contact.html" class="this">Contact</a></li>
        </ul>
      </nav>
    </header>
    <div id="wrapper">
      <section>
        <ul id="gallery">
          <li>
            <a href="img/numbers-01.jpg">
              <img src="img/numbers-01.jpg" alt="">
              <p>Experimentation with color and texture.</p>
            </a>
          </li>
          <li>
            <a href="img/numbers-02.jpg">
              <img src="img/numbers-02.jpg" alt="">
              <p>Playing with blending modes in Photoshop.</p>
            </a>
          </li>
        </ul>
      </section>
      <footer>
        <a href="http://twitter.com/nickrp"><img src="img/twitter-wrap.png" alt="Twitter Logo" class="social-icon"></a>
        <a href="http://facebook.com/nickpettit"><img src="img/facebook-wrap.png" alt="Facebook Logo" class="social-icon"></a>
        <p>&copy; 2016 Nick Pettit.</p>
      </footer>
    </div>
  <script src="js/app.js"></script>
  </body>
</html>
Steve Olsen
Steve Olsen
1,694 Points

works fine in firefox dev edition console the way i did it by class. it might not be the way that the treehouse program wants it but i successfully solved it and im reporting it to tech support.

any advice is still welcome. i am always open to learning

thanks Steve

2 Answers

Kieran Barker
Kieran Barker
15,028 Points
Kieran Barker
Kieran Barker
15,028 Points

You just need to be more specific, like you would with CSS. If I wanted to change all nav links to red, I'd do this in CSS:

nav a {
  color: #f00;
}

It's the same selector here:

let navigationLinks = document.querySelectorAll('nav a');
Steve Olsen
Steve Olsen
1,694 Points
Steve Olsen
Steve Olsen
1,694 Points

ah, so i was trying to grab the <li> elements, i should have tried for the <a> elements. thank you for the clarification.

Kieran Barker
Kieran Barker
15,028 Points
Kieran Barker
Kieran Barker
15,028 Points

No problem. You can mark this question as solved by choosing a best answer :)