Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript Express Basics Parameters, Query Strings, and Modularizing Routes Linking Around the Application

Ismayil Aliyev
Ismayil Aliyev
18,560 Points
Posted by Ismayil Aliyev
Ismayil Aliyev
18,560 Points

Error: Cannot set headers after they are sent to client (for redirecting when there is no side variable)

In the redirecting challenge, I wrote code exact as in video and it works. But command line gives me such kind of message:

Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client

Please, help me to understand why I got such a message even if app works properly, and how can I solve it or should I?

Michael Hulet
Michael Hulet
47,913 Points
Michael Hulet
Michael Hulet
47,913 Points

You've called res.set (or a related method) sometime after response.send, which isn't allowed. We'd need to know more about your code to point to a specific line

2 Answers

Ismayil Aliyev
Ismayil Aliyev
18,560 Points
Ismayil Aliyev
Ismayil Aliyev
18,560 Points

Dear friends, I could figure out why cmd was giving me such kind of error. 

router.get('/:id', (req, res) => {
    const { side } = req.query;
    const { id } = req.params;
    if(!side){
      return res.redirect(`/cards/${id}?side=question`)
    }
    const text = cards[id][side];
    const { hint } = cards[id];

    const templateData = { id, text };

    if ( side === 'question' ) {
      templateData.hint = hint;
      templateData.sideToShow = 'answer';
      templateData.sideToShowDisplay = 'Answer';
    } else if ( side === 'answer' ) {
      templateData.sideToShow = 'question';
      templateData.sideToShowDisplay = 'Question';
    }

    res.render('card', templateData);
});

The main reason was router.get() method couldn't finish its work because of redirecting. I found solution in writing return value before redirecting. Thanks a lot for your attention :) .

Victoria Medley
Victoria Medley
17,085 Points

What do you mean by this? Where did you put the return value and what did you write exactly? Could you post a snippet of the completed code? I am stuck on the same issue, I tried what you said but cannot figure it out.

Gabbie Metheny
Gabbie Metheny
33,778 Points
Gabbie Metheny
Gabbie Metheny
33,778 Points

Andrew addresses this a couple videos later, here. Basically, the rest of the router.get() function tries to execute, so we're trying to redirect and render simultaneously. Attempting to render after the redirect is what's causing the console error. Using the return keyword breaks us out of the router.get() function when we redirect, before the res.render().

Jaime Jesus Guerra Torres
Jaime Jesus Guerra Torres
16,954 Points
Jaime Jesus Guerra Torres
Jaime Jesus Guerra Torres
16,954 Points

I solved it, encasing the rest of the code in a "else" statement

router.get('/:id', (req, res) => {
    const { side } = req.query;
    const { id } = req.params;

    if(!side) {
        res.redirect(`/cards/${id}?side=question`);
    } else {
        const text = cards[id][side];
        const { hint } = cards[id];

        const templateData = { text, id };

        if (side === 'question') {
            templateData.hint = hint;
            templateData.sideToShow = 'answer';
            templateData.sideToShowDisplay = 'Answer';
        } else if ( side === 'answer' ) {
            templateData.sideToShow = 'question';
            templateData.sideToShowDisplay = 'Question';
        }

        res.render('card', templateData);
    }
});