Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Object-Oriented Python Dice Roller RPG Roller

Xiaobao Yu
PLUS
Xiaobao Yu
Courses Plus Student 4,346 Points

Don't know why it's not working - Hand.roll()

I tried the code in the workspace and it works. I don't know why it's not working.

dice.py
import random


class Die:
    def __init__(self, sides=2):
        if sides < 2:
            raise ValueError("Can't have fewer than two sides")
        self.sides = sides
        self.value = random.randint(1, sides)

    def __int__(self):
        return self.value

    def __add__(self, other):
        return int(self) + other

    def __radd__(self, other):
        return self + other


class D20(Die):
    def __init__(self):
        super().__init__(sides=20)
hands.py
from dice import D20

class Hand(list):
    def __init__(self, *args, **kwargs):
        super().__init__(self, *args, **kwargs)

    def roll(self, size=1):
        for _ in range(size):
            self.append(D20())

    @property
    def total(self):
        return sum(self)

1 Answer

Steven Parker
Steven Parker
231,236 Points

The instructions said "I want to get back an instance of Hand with two D20s rolled in it". So that means the "roll" method will need to return that instance, and there's no "return" statement in the code now.

Also, since the method is being called directly on the class, that would imply that the instance needs to be created inside the method, and the method should be a class method.