Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript and the DOM (Retiring) Getting a Handle on the DOM Practice Selecting Elements

tal Shnitzer
PLUS
tal Shnitzer
Courses Plus Student 5,242 Points
Posted by tal Shnitzer
tal Shnitzer
Courses Plus Student 5,242 Points

DOM course final challenge step 1

this is my answer: let nav = document.querySelector('nav'); let navigationLinks = nav.querySelectorAll('ul>li'); let galleryLinks; let footerImages;

js/app.js 
let nav = document.querySelector('nav');
let navigationLinks = nav.querySelectorAll('ul>li');
let galleryLinks;
let footerImages;
index.html 
<!DOCTYPE html>
<html>
  <head>
    <meta charset="utf-8">
    <title>Nick Pettit | Designer</title>
    <link rel="stylesheet" href="css/normalize.css">
    <link href='http://fonts.googleapis.com/css?family=Changa+One|Open+Sans:400italic,700italic,400,700,800' rel='stylesheet' type='text/css'>
    <link rel="stylesheet" href="css/main.css">
    <link rel="stylesheet" href="css/responsive.css">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
  </head>
  <body>
    <header>
      <a href="index.html" id="logo">
        <h1>Nick Pettit</h1>
        <h2>Designer</h2>
      </a>
      <nav>
        <ul>
          <li><a href="index.html" class="selected">Portfolio</a></li>
          <li><a href="about.html">About</a></li>
          <li><a href="contact.html">Contact</a></li>
        </ul>
      </nav>
    </header>
    <div id="wrapper">
      <section>
        <ul id="gallery">
          <li>
            <a href="img/numbers-01.jpg">
              <img src="img/numbers-01.jpg" alt="">
              <p>Experimentation with color and texture.</p>
            </a>
          </li>
          <li>
            <a href="img/numbers-02.jpg">
              <img src="img/numbers-02.jpg" alt="">
              <p>Playing with blending modes in Photoshop.</p>
            </a>
          </li>
        </ul>
      </section>
      <footer>
        <a href="http://twitter.com/nickrp"><img src="img/twitter-wrap.png" alt="Twitter Logo" class="social-icon"></a>
        <a href="http://facebook.com/nickpettit"><img src="img/facebook-wrap.png" alt="Facebook Logo" class="social-icon"></a>
        <p>&copy; 2016 Nick Pettit.</p>
      </footer>
    </div>
  <script src="js/app.js"></script>
  </body>
</html>
tal Shnitzer
tal Shnitzer
Courses Plus Student 5,242 Points
tal Shnitzer
tal Shnitzer
Courses Plus Student 5,242 Points

check result: "Bummer! The wrong links or elements were selected " what is wrong? what is the correct answer?

1 Answer

Steven Parker
Steven Parker
231,032 Points
Steven Parker
Steven Parker
231,032 Points

The challenge asks for "all links in the nav element". But links are represented by "a" tags ("li" is for list items).

Also, if you've already select the nav element, your next step would only need to select the links (you would not need a combined selector).

tal Shnitzer
tal Shnitzer
Courses Plus Student 5,242 Points
tal Shnitzer
tal Shnitzer
Courses Plus Student 5,242 Points

yes. the problem indeed was with the a being a tag. thanks. fixed it and it works

Shalom Dahal
Shalom Dahal
1,534 Points
Shalom Dahal
Shalom Dahal
1,534 Points

Hey! but as the <a> tags are inside <li>, shouldnt just selecting document.querySelectorAll('nav li'); work ?

Steven Parker
Steven Parker
231,032 Points
Steven Parker
Steven Parker
231,032 Points

You're right that the "li" is a parent of the link, but the challenge is looking for the links themselves.