Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Object-Oriented Python Dice Roller RPG Roller

Oprea Mihai
Oprea Mihai
5,592 Points

dice roll

Can you help me? I'm out of ideeas and I tried a lot of things. I don't get it to work not even in my PyCharm. thank you !

dice.py
import random


class Die:
    def __init__(self, sides=2):
        if sides < 2:
            raise ValueError("Can't have fewer than two sides")
        self.sides = sides
        self.value = random.randint(1, sides)

    def __int__(self):
        return self.value

    def __add__(self, other):
        return int(self) + other

    def __radd__(self, other):
        return self + other
class D20(Die):
    def __init__(self):
        super().__init__(sides=20)
hands.py
from dice import D20

class Hand(list):
    def __init__(self):
        super().__init__(size=2,die_class=D6)

    def roll(self,size,die_class):  
        for _ in range(size): # aici creem obiectele importate din clasa de D6(zarurile)
            self.append(die_class())
        self.sort()

    def _by_value(self,value):
        dice=[]
        for die in self:
            if die == value:
                dice.append(die)
        return dice

    @property
    def total(self):
        return sum(self)
Oprea Mihai
Oprea Mihai
5,592 Points

I mean the hands.py

1 Answer

Steven Parker
Steven Parker
231,236 Points

Here's a few hints:

  • you may not need to override __init__
  • you should also not need a _by_value method
  • the roll method does need a size argument, but it should not require any other argument(s)
  • the roll method will be used to create instances, so it might help to make it a class method
  • you won't need to sort anything