Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript and the DOM (Retiring) Getting a Handle on the DOM Selecting Multiple Elements

Posted by Katarzyna Wójtowicz
Katarzyna Wójtowicz
Courses Plus Student 4,842 Points

Could you please explain to me why this version is not accepted?

It's not passing the verification, but lines were colored correctly.

js/app.js 
var listItems = document.querySelector("#rainbow");
var colors = ["#C2272D", "#F8931F", "#FFFF01", "#009245", "#0193D9", "#0C04ED", "#612F90"];

for(var i = 0; i < colors.length; i ++) {
  listItems.children[i].style.color = colors[i];    
}
index.html 
<!DOCTYPE html>
<html>
  <head>
    <title>Rainbow!</title>
  </head>
  <body>
    <ul id="rainbow">
      <li>This should be red</li>
      <li>This should be orange</li>
      <li>This should be yellow</li>
      <li>This should be green</li>
      <li>This should be blue</li>
      <li>This should be indigo</li>
      <li>This should be violet</li>
    </ul>
    <script src="js/app.js"></script>
  </body>
</html>

2 Answers

Martin Balon
Martin Balon
43,651 Points
Martin Balon
Martin Balon
43,651 Points

Hi Katarzyna, The code you posted works but I guess the challenge checks whether listItems contains an array or a collection of items - it seems that they don't want you to change for loop. There are multiple ways how to achieve that. I've used querySelector on ul and extracted children right away to get a collection of all li. Or you can use getElementsByTagName which returns an array by default. 

var listItems = document.getElementsByTagName('li');
var colors = ["#C2272D", "#F8931F", "#FFFF01", "#009245", "#0193D9", "#0C04ED", "#612F90"];

for(var i = 0; i < colors.length; i ++) {
  listItems[i].style.color = colors[i];    
}

var listItems = document.querySelector("#rainbow").children;
var colors = ["#C2272D", "#F8931F", "#FFFF01", "#009245", "#0193D9", "#0C04ED", "#612F90"];

for(var i = 0; i < colors.length; i ++) {
  listItems[i].style.color = colors[i];    
}
Katarzyna Wójtowicz
PLUS
Katarzyna Wójtowicz
Courses Plus Student 4,842 Points
Katarzyna Wójtowicz
Katarzyna Wójtowicz
Courses Plus Student 4,842 Points

Hi Martin,

Thank you so much for your explanation, it helped! :)