Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python

Murat Mermerkaya
Murat Mermerkaya
2,346 Points
Posted by Murat Mermerkaya
Murat Mermerkaya
2,346 Points

Capitalism the game

What is wrong with this code?

hands.py 
from dice import D6


class Hand(list):
    def __init__(self, size=0, die_class=None, *args, **kwargs):
        if not die_class:
            raise ValueError("You must provide a die class")
        super().__init__()

        for _ in range(size):
            self.append(die_class())
        self.sort()

    def _by_value(self, value):
        dice = []
        for die in self:
            if die == value:
                dice.append(die)
        return dice


class CapitalismHand(Hand):
    def __init__(self):
        super().__init__(size = 2, die_class = D6)

    @property
    def doubles(self):
        if self._by_value[0] =self._by_value[1]:
            True
        else:
            return False 


    @property
    def ones(self):
        return self._by_value(1)

    @property
    def twos(self):
        return self._by_value(2)

    @property
    def threes(self):
        return self._by_value(3)

    @property
    def fours(self):
        return self._by_value(4)

    @property
    def fives(self):
        return self._by_value(5)

    @property
    def sixes(self):
        return self._by_value(6)

    @property
    def _sets(self):
        return {
            1: len(self.ones),
            2: len(self.twos),
            3: len(self.threes),
            4: len(self.fours),
            5: len(self.fives),
            6: len(self.sixes)
        }

3 Answers

Steve Hunter
Steve Hunter
57,712 Points
Steve Hunter
Steve Hunter
57,712 Points

I'm even later ... :wink:

You can just return the result of the comparison. That evaluates to True or False, which is what diverts the code through the if structure. So there's no need for the if/else as the comparison itself does it for you:

    @property
    def doubles(self):
        return self[0] == self[1]

I'm off to look for help on the second part of this challenge now, which is what I was hoping this post was about! :smile:

Steve.

evanfiddler
evanfiddler
22,275 Points
evanfiddler
evanfiddler
22,275 Points

Hi Murat,

I might be a little late to this, however, I believe one of problems with your code is that you forgot a 'return' before your 'True'.

Second, you've called a method (_by_value) on your self object and then tried to subscript it using [0] and [1]...this is not possible. 'Self', in your instance, is already an extension of the list module, meaning that 'self', by itself, is already a list.

Subscripting the object 'self' should give you what you want:

Last, you are attempting to use the assignment operator on 'self' using the '=' instead of the '==' operator.

@property
def doubles(self):
    if self[0] == self[1]: # was 'if self._by_value[0] =self._by_value[1]:'
        return True # was 'True'
    else:
        return False

Hope that helps. Evan

evanfiddler
evanfiddler
22,275 Points
evanfiddler
evanfiddler
22,275 Points

Steve's answer! +1

This is a much more Pythonic way to do it.

Steve Hunter
Steve Hunter
57,712 Points

I wouldn't be surprised if there was a better way, though! :+1: