Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript Object-Oriented JavaScript Getters and Setters Creating Setter Methods

Posted by Zak Mosbacher
.a{fill-rule:evenodd;}techdegree seal-36
Zak Mosbacher
Full Stack JavaScript Techdegree Graduate 16,080 Points

Cannot set property level of #<Student> which has only a getter

Hey, I dont understand why this setter is not correct, thanks for the help. :)

creating_setters.js 
class Student {
    constructor(gpa, credits){
        this.gpa = gpa;
        this.credits = credits;
    }

    stringGPA() {
        return this.gpa.toString();
    }


    get level() {
        if (this.credits > 90 ) {
            return 'Senior';
        } else if (this.credits > 60) {
            return 'Junior';
        } else if (this.credits > 30) {
            return 'Sophomore';
        } else {
            return 'Freshman';
        }
    }
    set major(major){
        if(this.level = 'Senior' || 'Junior'){
        this._major = major;
      }else if(Student.level = 'Sophomore' || 'Freshman'){
        this._major = 'None';
      }
    }
}

var student = new Student(3.9, 60);

1 Answer

Steven Parker
Steven Parker
231,269 Points
Steven Parker
Steven Parker
231,269 Points

First, remember that the equality comparison operator is "==" and just a single "=" is an assignment operator.

Then, logical combining only works with complete comparison expressions, for example:

if (count == 3 || 4)           // this test will always be "true"
if (count == 3 || count == 4)  // but this one is true only when count is either 3 or 4

And you probably didn't intend to refer to the class itself by name ("Student") instead of referring to the instance ("this").

Zak Mosbacher
.a{fill-rule:evenodd;}techdegree seal-36
Zak Mosbacher
Full Stack JavaScript Techdegree Graduate 16,080 Points

Thanks!