Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript Object-Oriented JavaScript Getters and Setters Creating Setter Methods

Nikhil J
Nikhil J
8,521 Points

Bummer: Your setter method is returning the wrong value for the major property.

What am I doing wrong here?

creating_setters.js
class Student {
    constructor(gpa, credits){
        this.gpa = gpa;
        this.credits = credits;
    }

    stringGPA() {
        return this.gpa.toString();
    }

    get level() {
        if (this.credits > 90 ) {
            return 'Senior';
        } else if (this.credits > 60) {
            return 'Junior';
        } else if (this.credits > 30) {
            return 'Sophomore';
        } else {
            return 'Freshman';
        }
    }
    get major() {
      return this._major;
    }
    set major(major) {
        this._major = major;
        if(this._major == "Junior")  {
            this._major = "Junior";
        }
        if(this._major == "Senior")  {
            this._major = "Senior";
        }
        if(this._major == "Sophomore" || this._major == "Freshman") {
            this._major = "None"; 
        }

    }
}

var student = new Student(3.9, 60);

1 Answer

Robert Manolis
STAFF
Robert Manolis
Treehouse Guest Teacher

Hey Nikhil J , nice work. It looks like you are close on this one. But the setter method is supposed the check if the this.level === 'senior' or this.level === 'junior', etc. And then the backing property gets set to the parameter being passed to the setter. Unless that param is freshman or sophomore. Then the backing property gets set to 'none'.

Also, you don't need to set the backing property initially before the if statements. And you should avoid using the loose equality operator unless you're absolutely sure that's what you want because otherwise it can lead to unexpected results. So when comparing values, you should pretty much always be using the strict equality operator: ===.

Nikhil J
Nikhil J
8,521 Points

Thanks, Robert, that cleared it for me.