Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Objects Delivering the MVP Applying a Discount Code

michael figueroa
michael figueroa
5,680 Points

applying discount code

I literally changed nothing from the first part of the challenge, but as soon as i added the validation for loop and try catch block the first task no longer works which is supposed to just take the code and uppercase it.

Order.java
public class Order {
  private String itemName;
  private int priceInCents;
  private String discountCode;

  private String normalizeDiscountCode(String oldDiscountCode)
  {

    for(int i = 0;i < oldDiscountCode.length();i++)
    {
      if(!(oldDiscountCode.charAt(i) <= 'z') || oldDiscountCode.charAt(i) != '$')
      {
        throw new IllegalArgumentException("Invalid discount code.");
      }
    }
    return oldDiscountCode.toUpperCase();
  }

  public Order(String itemName, int priceInCents) {
    this.itemName = itemName;
    this.priceInCents = priceInCents;
  }

  public String getItemName() {
    return itemName;
  }

  public int getPriceInCents() {
    return priceInCents;
  }

  public String getDiscountCode() {
    return discountCode;
  }

  public void applyDiscountCode(String discountCode) {
    try
    {
      this.discountCode = normalizeDiscountCode(discountCode);
    }
    catch(IllegalArgumentException iae)
    {
      System.out.println(iae.getMessage());
    }

  }
}
Example.java
public class Example {

  public static void main(String[] args) {
    // This is here just for example use cases.

    Order order = new Order(
            "Yoda PEZ Dispenser",
            600);

    // These are valid.  They are letters and the $ character only
    order.applyDiscountCode("abc");
    order.getDiscountCode(); // ABC

    order.applyDiscountCode("$ale");
    order.getDiscountCode(); // $ALE


    try {
      // This will throw an exception because it contains numbers
      order.applyDiscountCode("ABC123");
    } catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }
    try {
      // This will throw as well, because it contains a symbol.
      order.applyDiscountCode("w@w");
    }catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }

  }
}

1 Answer

Hi Michael,

You're using a logical OR comparison in your validation but the logic is that it can't be a letter AND it can't be a $

Also, checking if the character is less than or equal to 'z' doesn't properly verify that it's a letter.

If you take a look at an ascii chart you'll see that there are characters that are less than 'z' but they are not letters.

http://www.asciitable.com/

Take a look at Character.isLetter() to help with checking if you have a letter. https://docs.oracle.com/javase/8/docs/api/java/lang/Character.html#isLetter-char-

I believe Craig used this at some point in the lessons.