Welcome to the Treehouse Community
Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.
Looking to learn something new?
Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.
Start your free trial
Joakim Sjöstedt
1,975 PointsApplying a discount code
What am I missing in the normalize method? Compiler says there are errors both with the exception and isLetter... and is the string supposed to be converted to char?
public class Order {
private String itemName;
private int priceInCents;
private String discountCode;
public Order(String itemName, int priceInCents) {
this.itemName = itemName;
this.priceInCents = priceInCents;
}
private String normalizeDiscountCode(String discountCode){
if(! Character.isLetter(discountCode.toCharArray())) { // || discountCode.toCharArray('$') !=-1){
throw new illegalArgumentException(discountCode + " invalid discount code");}
return discountCode.toUpperCase();
}
public String getItemName() {
return itemName;
}
public int getPriceInCents() {
return priceInCents;
}
public String getDiscountCode() {
return discountCode;
}
public void applyDiscountCode(String discountCode) {
this.discountCode = normalizeDiscountCode(discountCode);
}
}
public class Example {
public static void main(String[] args) {
// This is here just for example use cases.
Order order = new Order(
"Yoda PEZ Dispenser",
600);
// These are valid. They are letters and the $ character only
order.applyDiscountCode("abc");
order.getDiscountCode(); // ABC
order.applyDiscountCode("$ale");
order.getDiscountCode(); // $ALE
try {
// This will throw an exception because it contains numbers
order.applyDiscountCode("ABC123");
} catch (IllegalArgumentException iae) {
System.out.println(iae.getMessage()); // Prints "Invalid discount code"
}
try {
// This will throw as well, because it contains a symbol.
order.applyDiscountCode("w@w");
}catch (IllegalArgumentException iae) {
System.out.println(iae.getMessage()); // Prints "Invalid discount code"
}
}
}
Joakim Sjöstedt
1,975 PointsHmm, almost there, but still doesn't quite go through: Order.java:13: error: no suitable method found for isLetter(String) if(Character.isLetter(discountCode) || disc =='$') {
private String normalizeDiscountCode(String discountCode){
for(char disc : discountCode.toCharArray()) {
if(Character.isLetter(discountCode) || disc =='$') {
return discountCode.toUpperCase(); }
else{
throw new IllegalArgumentException(discountCode + " invalid discount code");}
}
}
4 Answers
Daniel Gelabert
944 PointsThink about it, discountCode is a String, while the method asks for a char Character.isLetter(char).
Joakim Sjöstedt
1,975 PointsOK, so discountCode.charAt(disc)... makes sense :) Thanks :) But now it says that either task 1 is invalid for whatever reason:
private String normalizeDiscountCode(String discountCode)
{
for(char disc : discountCode.toCharArray())
{
if(! Character.isLetter(discountCode.charAt(disc)) || disc =='$')
{
throw new IllegalArgumentException(discountCode + " invalid discount code");
}
}
return discountCode.toUpperCase();
}
Joakim Sjöstedt
1,975 PointsOh, and how do I write so that it becomes code here on the forum? Some of the code got converted, and some didn't...
Joakim Sjöstedt
1,975 PointsStill stuck... What do I do if I don't find any help? Task 1 is still the way it was before. Havn't changed it, but compiler says it's not the same...
Daniel Gelabert
944 PointsI asked the same question a few days ago. Think about it, when there's a '$' the ! Character.isLetter(discountCode.charAt(disc)) is true and goes inside the if code. Check that and you will find the answer. In fact task 1 is still valid, but for some reason the website returns this message.
Daniel Gelabert
944 PointsDaniel Gelabert
944 PointsI think the main problem is that you are using a char array (discountCode.toCharArray()) as a char, and thats why the compiler crashes. You should use a for structure for each char in the char array, as in this example https://stackoverflow.com/questions/5238491/check-if-string-contains-only-letters