Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Android Android Lists and Adapters (2015) Lists with RecyclerViews Using a Layout Manager

Lewis Harwood
Lewis Harwood
2,719 Points

App is crashing when I press the hourly button, daily function still works though :(

MainActivity.java package com.lewisharwood.stormy;

import android.content.Context; import android.content.Intent; import android.graphics.drawable.Drawable; import android.net.ConnectivityManager; import android.net.NetworkInfo; import android.support.v7.app.AppCompatActivity; import android.os.Bundle; import android.util.Log; import android.view.View; import android.widget.ImageView; import android.widget.ProgressBar; import android.widget.TextView; import android.widget.Toast;

import com.lewisharwood.stormy.weather.Current; import com.lewisharwood.stormy.weather.Day; import com.lewisharwood.stormy.weather.Forecast; import com.lewisharwood.stormy.weather.Hour;

import org.json.JSONArray; import org.json.JSONException; import org.json.JSONObject;

import java.io.IOException;

import butterknife.BindView; import butterknife.ButterKnife; import butterknife.OnClick; import okhttp3.Call; import okhttp3.Callback; import okhttp3.OkHttpClient; import okhttp3.Request; import okhttp3.Response;

public class MainActivity extends AppCompatActivity {

public static final String TAG = MainActivity.class.getSimpleName();
public static final String DAILY_FORECAST = "DAILY_FORECAST";
public static final String HOURLY_FORECAST = "HOURLY_FORECAST";

private Forecast mForecast;


@BindView(R.id.time_label) TextView mTimeLabel;
@BindView(R.id.temperatureLabel) TextView mTemperatureLabel;
@BindView(R.id.humidityValue) TextView mHumidityValue;
@BindView(R.id.precipValue) TextView mPrecipValue;
@BindView(R.id.summaryLabel) TextView mSummaryLabel;
@BindView(R.id.iconImageView)
ImageView mIconImageView;
@BindView(R.id.refreshImageView) ImageView mRefreshImageView;
@BindView(R.id.progressBar) ProgressBar mProgressBar;

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);
    ButterKnife.bind(this);

    mProgressBar.setVisibility(View.INVISIBLE);

    final double latitude = 37.8267;
    final double longitude = -122.4233;

    mRefreshImageView.setOnClickListener(new View.OnClickListener() {
        @Override
        public void onClick(View v) {
            getForecast(latitude, longitude);
        }
    });

    getForecast(latitude, longitude);

    Log.d(TAG, "Main UI code is running");
}

private void getForecast(double latitude, double longitude) {
    String apiKey = "d9248d8506b0a15852b0d2cc31b4a29b";
    String forecastUrl = "https://api.darksky.net/forecast/" + apiKey +
            "/" + latitude + "," + longitude + "?units=si";


    if (isNetworkAvailiable()) {
        toggleRefresh();

    OkHttpClient client = new OkHttpClient();
    Request request = new Request.Builder()
            .url(forecastUrl)
            .build();

    Call call = client.newCall(request);
    call.enqueue(new Callback() {
        @Override
        public void onFailure(Call call, IOException e) {
            runOnUiThread(new Runnable() {
                @Override
                public void run() {
                    toggleRefresh();
                }
            });
            alertUserAboutError();
        }

        @Override
        public void onResponse(Call call, Response response) throws IOException {
            runOnUiThread(new Runnable() {
                @Override
                public void run() {
                    toggleRefresh();
                }
            });
            try {
                String jsonData = response.body().string();
                Log.v(TAG,  jsonData);
                if (response.isSuccessful()) {
                    mForecast = parseForecastDetails(jsonData);
                    runOnUiThread(new Runnable() {
                        @Override
                        public void run() {
                            updateDisplay();
                        }
                    });
                }
                else {
                    alertUserAboutError();
                }
            } catch (IOException e) {
                Log.e(TAG, "Exception caught : ", e);
            }
            catch (JSONException e) {
                Log.e(TAG, "Exception caught: ", e);
            }
        }
    });
    }
    else{
        Toast.makeText(this, R.string.network_unavailable,
                Toast.LENGTH_LONG).show();
    }
}

private void toggleRefresh() {
    if (mProgressBar.getVisibility() == View.INVISIBLE) {
    mProgressBar.setVisibility(View.VISIBLE);
    mRefreshImageView.setVisibility(View.INVISIBLE);

    }
    else{

        mProgressBar.setVisibility(View.INVISIBLE);
        mRefreshImageView.setVisibility(View.VISIBLE);
    }
}

private void updateDisplay() {
    Current current= mForecast.getCurrent();
    mTemperatureLabel.setText(current.getTemperature() +"");
    mTimeLabel.setText("At " + current.getFormattedTime()+ " it will be");
    mHumidityValue.setText(current.getHumidity()+ "");
    mPrecipValue.setText(current.getPrecipChance()+ "%");
    mSummaryLabel.setText(current.getSummary());

    Drawable drawable = getResources().getDrawable(current.getIconId());
    mIconImageView.setImageDrawable(drawable);
}

private Forecast parseForecastDetails(String jsonData) throws JSONException{
    Forecast forecast = new Forecast();

    forecast.setCurrent(getCurrentDetails(jsonData));
    forecast.setHourlyForecast(getHourlyForecast(jsonData));
    forecast.setDailyForecast(getDailyForecast(jsonData));


    return forecast;
}




private Hour[] getHourlyForecast(String jsonData) throws JSONException {
    JSONObject forecast = new JSONObject(jsonData);
    String timezone = forecast.getString("timezone");
    JSONObject hourly = forecast.getJSONObject("hourly");
    JSONArray data = hourly.getJSONArray("data");

    Hour[] hours = new Hour[data.length()];

    for (int i = 0; i < data.length(); i++) {
        JSONObject jsonHour = data.getJSONObject(i);
        Hour hour = new Hour();

        hour.setSummary(jsonHour.getString("summary"));
        hour.setTemperature(jsonHour.getDouble("temperature"));
        hour.setIcon(jsonHour.getString("icon"));
        hour.setTime(jsonHour.getLong("time"));
        hour.setTimeZone(timezone);

        hours[i] = hour;
    }
    return hours;
}

private Day[] getDailyForecast(String jsonData) throws JSONException {
    JSONObject forecast = new JSONObject(jsonData);
    String timezone = forecast.getString("timezone");
    JSONObject daily = forecast.getJSONObject("daily");
    JSONArray data= daily.getJSONArray("data");

    Day[] days = new Day[data.length()];

    for (int i = 0; i < data.length(); i++){
        JSONObject jsonDay= data.getJSONObject(i);
        Day day = new Day();

        day.setSummary(jsonDay.getString("summary"));
        day.setIcon(jsonDay.getString("icon"));
        day.setTemperatureMax(jsonDay.getDouble("temperatureMax"));
        day.setTime(jsonDay.getLong("time"));
        day.setTimezone(timezone);

        days[i] = day;
    }

    return days;
}

private Current getCurrentDetails(String jsonData) throws JSONException {
    JSONObject forecast = new JSONObject(jsonData);
    String timezone = forecast.getString("timezone");
    Log.i(TAG, "From JSON; " + timezone);

    JSONObject currently = forecast.getJSONObject("currently");

    Current current = new Current();
    current.setHumidity(currently.getDouble("humidity"));
    current.setTime(currently.getLong("time"));
    current.setIcon(currently.getString("icon"));
    current.setPrecipChance(currently.getDouble("precipProbability"));
    current.setSummary(currently.getString("summary"));
    current.setTemperature(currently.getDouble("temperature"));
    current.setTimeZone(timezone);

    Log.d(TAG, current.getFormattedTime());

    return current;
    }

private boolean isNetworkAvailiable() {
    ConnectivityManager manager = (ConnectivityManager)
            getSystemService(Context.CONNECTIVITY_SERVICE);
    NetworkInfo networkInfo = manager.getActiveNetworkInfo();
    boolean isAvailable = false;
    if (networkInfo != null && networkInfo.isConnected()) {
        isAvailable = true;
    }

    return isAvailable;
}

private void alertUserAboutError() {
    AlertDialogueFragment dialog = new AlertDialogueFragment();
    dialog.show(getFragmentManager(), "error_dialog");
}

@OnClick (R.id.dailyButton)
public void startDailyActivity(View view){
    Intent intent = new Intent(this, DailyForecastActivity.class);
    intent.putExtra(DAILY_FORECAST, mForecast.getDailyForecast());
    startActivity(intent);
}
@OnClick (R.id.hourlyButton)
public void startHourlyActivity(View view) {
    Intent intent = new Intent(this, DailyForecastActivity.class);
    intent.putExtra(HOURLY_FORECAST, mForecast.getHourlyForecast());
    startActivity(intent);
}

};

HourAdapter.java package com.lewisharwood.stormy.adapters;

import android.support.v7.widget.RecyclerView; import android.view.LayoutInflater; import android.view.View; import android.view.ViewGroup; import android.widget.ImageView; import android.widget.TextView;

import com.lewisharwood.stormy.R; import com.lewisharwood.stormy.weather.Hour;

public class HourAdapter extends RecyclerView.Adapter<HourAdapter.HourViewHolder>{

private Hour[] mHours;

public HourAdapter(Hour[] hours) {
    mHours = hours;
}

@Override
public HourViewHolder onCreateViewHolder(ViewGroup parent, int viewType) {
    View view = LayoutInflater.from(parent.getContext())
            .inflate(R.layout.hourly_list_item, parent, false);
    HourViewHolder viewHolder = new HourViewHolder(view);
    return viewHolder;
}

@Override
public void onBindViewHolder(HourViewHolder holder, int position) {
    holder.injectHour(mHours[position]);
}

@Override
public int getItemCount() {
    return mHours.length;
}

public class HourViewHolder extends RecyclerView.ViewHolder {

    public TextView mTimeLabel;
    public TextView mSummaryLabel;
    public TextView mTemperatureLabel;
    public ImageView mIconImageView;


    public HourViewHolder(View itemView) {
        super(itemView);

        mTimeLabel = (TextView) itemView.findViewById(R.id.timeLabel);
        mSummaryLabel = (TextView) itemView.findViewById(R.id.summaryLabel);
        mTemperatureLabel = (TextView) itemView.findViewById(R.id.temperatureLabel);
        mIconImageView = (ImageView) itemView.findViewById(R.id.iconImageView);
    }


    public void injectHour(Hour hour) {
        mTimeLabel.setText(hour.getHour());
        mSummaryLabel.setText(hour.getSummary());
        mTemperatureLabel.setText(hour.getTemperature() + "");
        mIconImageView.setImageResource(hour.getIconId());
    }
}

}

HourlyForecastActivity.java package com.lewisharwood.stormy;

import android.content.Intent; import android.os.Parcelable; import android.support.v7.app.ActionBarActivity; import android.support.v7.app.AppCompatActivity; import android.os.Bundle; import android.support.v7.widget.LinearLayoutManager; import android.support.v7.widget.RecyclerView;

import com.lewisharwood.stormy.adapters.HourAdapter; import com.lewisharwood.stormy.weather.Hour;

import java.util.Arrays;

import butterknife.BindView; import butterknife.ButterKnife;

public class HourlyForecastActivity extends ActionBarActivity {

private Hour[] mHours;

@BindView(R.id.recyclerView) RecyclerView mRecyclerView;



@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_hourly_forecast);
    ButterKnife.bind(this);

    Intent intent = getIntent();
    Parcelable[] parcelables = intent.getParcelableArrayExtra(MainActivity.HOURLY_FORECAST);
    mHours = Arrays.copyOf(parcelables, parcelables.length, Hour[].class);

    HourAdapter adapter = new HourAdapter(mHours);
    mRecyclerView.setAdapter(adapter);

    RecyclerView.LayoutManager layoutManager = new LinearLayoutManager(this);
    mRecyclerView.setLayoutManager(layoutManager);

    mRecyclerView.setHasFixedSize(true);
}

}

activity_hourly_forecast.xml <?xml version="1.0" encoding="utf-8"?> <RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android" xmlns:app="http://schemas.android.com/apk/res-auto" xmlns:tools="http://schemas.android.com/tools" android:layout_width="match_parent" android:layout_height="match_parent" tools:context="com.lewisharwood.stormy.HourlyForecastActivity" android:background="@drawable/bg_gradient">

<android.support.v7.widget.RecyclerView
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    android:id="@+id/recyclerView"/>

</RelativeLayout>

Hour.java

package com.lewisharwood.stormy.weather;

import android.os.Parcel; import android.os.Parcelable;

import java.text.SimpleDateFormat; import java.util.Date;

public class Hour implements Parcelable{ private long mTime; private String mSummary; private double mTemperature; private String mIcon; private String mTimeZone;

    public Hour() { }

    public long getTime() {
        return mTime;
    }

    public void setTime(long time) {
        mTime = time;
    }

    public String getSummary() {
        return mSummary;
    }

    public void setSummary(String summary) {
        mSummary = summary;
    }

    public int getTemperature() {
        return (int) Math.round(mTemperature);
    }

    public void setTemperature(double temperature) {
        mTemperature = temperature;
    }

    public String getIcon() {
        return mIcon;
    }

    public int getIconId(){
        return Forecast.getIconId(mIcon);
    }

    public void setIcon(String icon) {
        mIcon = icon;
    }

    public String getTimeZone() {
        return mTimeZone;
    }

    public void setTimeZone(String timeZone) {
        mTimeZone = timeZone;
    }

    public String getHour(){
        SimpleDateFormat formatter = new SimpleDateFormat("h a");
        Date date = new Date(mTime * 1000);
        return formatter.format(date);
    }

@Override
public int describeContents() {
    return 0;
}

@Override
public void writeToParcel(Parcel dest, int flags) {
    dest.writeLong(mTime);
    dest.writeDouble(mTemperature);
    dest.writeString(mSummary);
    dest.writeString(mIcon);
    dest.writeString(mTimeZone);
}
private Hour(Parcel in){
    mTime = in.readLong();
    mTemperature = in.readDouble();
    mSummary = in.readString();
    mIcon = in.readString();
    mTimeZone = in.readString();
}

public static final Creator<Hour> CREATOR = new Creator<Hour>(){
    @Override
    public Hour createFromParcel(Parcel source) { {return new Hour(source);}
    }

    @Override
    public Hour[] newArray(int size) {
        return new Hour[size];
    }
    };
}

The code also gives me no errors when in android studio so I must have just written something completely wrong :/

1 Answer

Seth Kroger
Seth Kroger
56,413 Points

When you create the Intent to launch the new Activity, you're using DailyForecastActivity instead of HourlyForecastActivity.