Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Object-Oriented Python Dice Roller RPG Roller

Jigar Gor
PLUS
Jigar Gor
Courses Plus Student 1,568 Points

Adding a decorator to the Hands class

Upon calling Hand.roll(n), n number of D20 die should be in an instance of Hand returned by the class method roll(n). I have a feeling that my issue is either in how I am instantiating the list passed to cls or how I am importing/instantiating D20 die. D20 is a subclass of Die that is stored in dice.py

dice.py
import random


class Die:
    def __init__(self, sides=2):
        if sides < 2:
            raise ValueError("Can't have fewer than two sides")
        self.sides = sides
        self.value = random.randint(1, sides)

    def __int__(self):
        return self.value

    def __add__(self, other):
        return int(self) + other

    def __radd__(self, other):
        return self + other


class D20(Die):
    def __init__(self, sides = 20):
        super().__init__(sides)
hands.py
import D20 from dice
class Hand(list):
    @classmethod
    def roll(cls, num):
        die = []
        for _ in range(num):
            die.append(D20())
        return cls(die)

    @property
    def total(self):
        return sum(self)

1 Answer

Steven Parker
Steven Parker
231,236 Points

The "from" should come first in the import statement:

from dice import D20

Otherwise, good job! :+1:

Jigar Gor
Jigar Gor
Courses Plus Student 1,568 Points

Thanks! I also had to change the Die.D20() to just D20(), but that issue arose from tinkering around with the code to make it work.