Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript Loops, Arrays and Objects Simplify Repetitive Tasks with Loops The Refactor Challenge Solution

Posted by Raul Vega
Raul Vega
Courses Plus Student 3,803 Points

Refactor challenge #2

var html = '';
var red;
var green;
var blue;
var rgbColor;

for (var cc = 0; cc!==10; cc+=1){
  function randomRgbValue (){
  return Math.floor(Math.random() * 256 );
  }
  red = randomRgbValue();
  green = randomRgbValue();
  blue = randomRgbValue();
  rgbColor = 'rgb(' + red + ',' + green + ',' + blue + ')';
  html += '<div style="background-color:' + rgbColor + '"></div>';
}

document.write(html);
Timothy Wright-Bodine
Timothy Wright-Bodine
9,670 Points

Looks good! My only suggestion would be to put the randomRgbValue() function outside of the for loop so it is not recreated on every iteration.

1 Answer

roberthopman
roberthopman
16,502 Points
roberthopman
roberthopman
16,502 Points

Thanks